New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update validation error message for TXT record #58129
Conversation
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: App Entrypoints (~47 bytes added 📈 [gzipped])
Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used. Sections (~20 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
Link to Calypso live: https://calypso.live?image=registry.a8c.com/calypso/app:build-20130 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome - looks great!
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/6995885 Thank you @gius80 for including a screenshot in the description! This is really helpful for our translators. |
Translation for this Pull Request has now been finished. |
This PR update the validation error message when a user try to create a TXT record longer than 255 characters: it adds a link to support page to better explain TXT record's limitations. Merging on behalf or @gius80
Changes proposed in this Pull Request
Testing instructions
/domains/manage/[YOU-DOMAIN]/add-dns-record/[YOU-DOMAIN]
)Related to #56326