Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update validation error message for TXT record #58129

Merged
merged 3 commits into from Nov 26, 2021

Conversation

gius80
Copy link
Contributor

@gius80 gius80 commented Nov 16, 2021

Changes proposed in this Pull Request

  • This PR update the validation error message when a user try to create a TXT record longer than 255 characters: it adds a link to support page to better explain TXT record's limitations.

Markup on 2021-11-16 at 17:14:21

Markup on 2021-11-16 at 17:13:14

Testing instructions

  • Try add a new TXT DNS record longer than 255 characters for a domain managed by WordPress.com (Calypso url: /domains/manage/[YOU-DOMAIN]/add-dns-record/[YOU-DOMAIN])

Related to #56326

@gius80 gius80 added [Status] In Progress [Feature Group] Emails & Domains Features related to email integrations and domain management. labels Nov 16, 2021
@gius80 gius80 requested a review from a team as a code owner November 16, 2021 16:15
@gius80 gius80 self-assigned this Nov 16, 2021
@matticbot matticbot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Nov 16, 2021
@matticbot
Copy link
Contributor

matticbot commented Nov 16, 2021

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~47 bytes added 📈 [gzipped])

name                   parsed_size           gzip_size
entry-main                   +67 B  (+0.0%)      +21 B  (+0.0%)
entry-domains-landing        +67 B  (+0.0%)      +24 B  (+0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~20 bytes added 📈 [gzipped])

name     parsed_size           gzip_size
domains       +122 B  (+0.0%)      +20 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@github-actions
Copy link

github-actions bot commented Nov 16, 2021

@gius80 gius80 changed the title Update validation error message for TXT record (> 255 chars limit) Update validation error message for TXT record (WIP) Nov 16, 2021
@gius80 gius80 changed the title Update validation error message for TXT record (WIP) Update validation error message for TXT record Nov 22, 2021
Copy link
Contributor

@hambai hambai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome - looks great!

@hambai hambai merged commit c216cf7 into trunk Nov 26, 2021
@hambai hambai deleted the update/txt-record-validation-error branch November 26, 2021 08:58
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Nov 26, 2021
@a8ci18n
Copy link

a8ci18n commented Nov 26, 2021

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/6995885

Thank you @gius80 for including a screenshot in the description! This is really helpful for our translators.

@a8ci18n
Copy link

a8ci18n commented Dec 2, 2021

Translation for this Pull Request has now been finished.

nelsonec87 pushed a commit that referenced this pull request Dec 9, 2021
This PR update the validation error message when a user try to create a TXT record longer than 255 characters: it adds a link to support page to better explain TXT record's limitations.

Merging on behalf or @gius80
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature Group] Emails & Domains Features related to email integrations and domain management.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants