Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Domains: Add right-hand column to the transfer page #58662

Merged
merged 3 commits into from
Dec 3, 2021

Conversation

rafaelgallani
Copy link
Contributor

@rafaelgallani rafaelgallani commented Nov 30, 2021

Changes proposed in this Pull Request

Adds the right-hand column to the transfer page with a help text. This is part of the domain management redesign project described in pcYYhz-m2-p2.

Preview

Desktop

image

Mobile

image

Testing instructions

  • Go to "Upgrades > Domains";
  • Select one of your registered domains;
  • If you're in the live Calypso link, please append ?flags=domains/transfers-redesign to your URL to enable the appropriate feature flag;
  • Check that the second column is displayed correctly as in the screenshots above.

@github-actions
Copy link

github-actions bot commented Nov 30, 2021

@matticbot
Copy link
Contributor

matticbot commented Nov 30, 2021

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~225 bytes added 📈 [gzipped])

name     parsed_size           gzip_size
domains      +1590 B  (+0.1%)     +335 B  (+0.1%)
media          -26 B  (-0.0%)       +2 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~2 bytes added 📈 [gzipped])

name                                               parsed_size           gzip_size
async-load-design-playground                             -26 B  (-0.0%)       +2 B  (+0.0%)
async-load-design-blocks                                 -26 B  (-0.0%)       +2 B  (+0.0%)
async-load-design                                        -26 B  (-0.0%)       +2 B  (+0.0%)
async-load-calypso-post-editor-media-modal               -26 B  (-0.0%)       +2 B  (+0.0%)
async-load-calypso-post-editor-editor-media-modal        -26 B  (-0.0%)       +2 B  (+0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@rafaelgallani rafaelgallani marked this pull request as ready for review November 30, 2021 20:27
@rafaelgallani rafaelgallani requested a review from a team as a code owner November 30, 2021 20:27
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Nov 30, 2021
@rafaelgallani rafaelgallani added [Feature Group] Emails & Domains Features related to email integrations and domain management. and removed [Status] In Progress labels Nov 30, 2021
Copy link
Contributor

@leonardost leonardost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM! The only thing I noticed that is different from the design is that the gap between the two columns should be 48px, so each column should have a right/left padding of 24px.

I was going to mention that we are using at least three different approaches to the two column layout: @hambai's 12-column grid (#57111), @gius80's 2-column grid (#58653) and this with the Column component (nice find, btw!), but I saw you've already discussed this here https://github.com/Automattic/wp-calypso/pull/58653/files#r760789139 and a card was created, so it's all good 🙂

Edit: Oh, there's also a code conflict that should be solved before merging this - now the transfer options are rendered in a method.

Comment on lines +53 to +72
&-section-card {
background: var( --studio-gray-0 );
border-radius: 2px;
box-shadow: none;
padding: 24px;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a border-radius in the designs, I hadn't noticed it 😅 good eyes! We'll probably have to fix that in the other pages.

@rafaelgallani rafaelgallani force-pushed the update/transfer-domain-page-right-hand-column branch from c55c7c2 to 4de3e42 Compare December 3, 2021 15:24
@rafaelgallani
Copy link
Contributor Author

Rebased on trunk

@rafaelgallani rafaelgallani merged commit ccd2bf8 into trunk Dec 3, 2021
@rafaelgallani rafaelgallani deleted the update/transfer-domain-page-right-hand-column branch December 3, 2021 16:59
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 3, 2021
@a8ci18n
Copy link

a8ci18n commented Dec 3, 2021

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/7017152

Thank you @rafaelgalani for including a screenshot in the description! This is really helpful for our translators.

@a8ci18n
Copy link

a8ci18n commented Dec 9, 2021

Translation for this Pull Request has now been finished.

nelsonec87 pushed a commit that referenced this pull request Dec 9, 2021
* Add column component

* Add support link

* Fix column padding
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature Group] Emails & Domains Features related to email integrations and domain management.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants