Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pricing page: make product card features collapsable on mobile #59079

Merged
merged 3 commits into from
Dec 15, 2021

Conversation

monsieur-z
Copy link
Contributor

@monsieur-z monsieur-z commented Dec 10, 2021

Changes proposed in this Pull Request

This PR makes product cards in the pricing page collapsable on mobile. Note that the change is limited to actual product cards in the More Products section.

Testing instructions

  • Download the PR and run cloud or Calypso
  • Visit the pricing/plans page
  • Check that the page looks and behaves the same as in production on desktop
  • On mobile, check that cards in the More Products section are collapsed by default and can be expanded

Screenshots

Before After
Screen Shot 2021-12-10 at 2 28 27 PM Screen Shot 2021-12-10 at 2 28 12 PM

@github-actions
Copy link

github-actions bot commented Dec 10, 2021

@matticbot
Copy link
Contributor

matticbot commented Dec 10, 2021

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~210 bytes added 📈 [gzipped])

name                   parsed_size           gzip_size
plans                       +775 B  (+0.1%)     +210 B  (+0.1%)
jetpack-connect             +775 B  (+0.1%)     +210 B  (+0.1%)
jetpack-cloud-pricing       +775 B  (+0.2%)     +210 B  (+0.2%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@monsieur-z monsieur-z added [Size] S Small sized issue Jetpack Cloud Anything related to the Jetpack Cloud (cloud.jetpack.com) labels Dec 13, 2021
@monsieur-z monsieur-z force-pushed the improve/make-product-card-features-collapsable branch from 2c49e21 to dc4cf05 Compare December 13, 2021 19:37
@monsieur-z monsieur-z marked this pull request as ready for review December 13, 2021 19:38
@monsieur-z monsieur-z added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Status] Needs Design Review Add this when you'd like to get a review / feedback from the Design team on your PR labels Dec 13, 2021
@monsieur-z monsieur-z requested review from a team and keoshi December 13, 2021 19:38
@monsieur-z
Copy link
Contributor Author

@keoshi, should we apply the collapsable features to the Free and CRM cards as well?

@github-actions github-actions bot added the [Status] Design Input Requested Label automatically added to PRs where design feedback is requested label Dec 13, 2021
Copy link
Contributor

@cbauerman cbauerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! The a11y aspect of the header being a button are not wonderful, but I think that for such a limited use it is fine 👍

@keoshi
Copy link
Contributor

keoshi commented Dec 14, 2021

should we apply the collapsable features to the Free and CRM cards as well?

I think so, yeah. It makes the interaction with all the cards in the entire section more expectable.

Everything else is looking great!

@monsieur-z monsieur-z force-pushed the improve/make-product-card-features-collapsable branch from dc4cf05 to e503264 Compare December 14, 2021 18:42
@monsieur-z
Copy link
Contributor Author

The a11y aspect of the header being a button are not wonderful

You're right @cbauerman, I made another pass at it.

Copy link
Contributor

@keoshi keoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great! Ship it.

@keoshi keoshi added [Status] Ready to Merge and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Status] Needs Design Review Add this when you'd like to get a review / feedback from the Design team on your PR [Status] Design Input Requested Label automatically added to PRs where design feedback is requested labels Dec 15, 2021
@monsieur-z monsieur-z merged commit f25dced into trunk Dec 15, 2021
@monsieur-z monsieur-z deleted the improve/make-product-card-features-collapsable branch December 15, 2021 14:14
@a8ci18n
Copy link

a8ci18n commented Dec 15, 2021

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/7043332

Thank you @monsieur-z for including a screenshot in the description! This is really helpful for our translators.

@a8ci18n
Copy link

a8ci18n commented Dec 24, 2021

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Jetpack Cloud Anything related to the Jetpack Cloud (cloud.jetpack.com) [Size] S Small sized issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants