-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pricing page: make product card features collapsable on mobile #59079
Pricing page: make product card features collapsable on mobile #59079
Conversation
Link to Calypso live: https://calypso.live?image=registry.a8c.com/calypso/app:build-22387 |
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~210 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
2c49e21
to
dc4cf05
Compare
@keoshi, should we apply the collapsable features to the Free and CRM cards as well? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! The a11y aspect of the header being a button are not wonderful, but I think that for such a limited use it is fine 👍
I think so, yeah. It makes the interaction with all the cards in the entire section more expectable. Everything else is looking great! |
dc4cf05
to
e503264
Compare
You're right @cbauerman, I made another pass at it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking great! Ship it.
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/7043332 Thank you @monsieur-z for including a screenshot in the description! This is really helpful for our translators. |
Translation for this Pull Request has now been finished. |
Changes proposed in this Pull Request
This PR makes product cards in the pricing page collapsable on mobile. Note that the change is limited to actual product cards in the More Products section.
Testing instructions
Screenshots