New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Seller experience: Make options requirement aware of current site plan #60711
Seller experience: Make options requirement aware of current site plan #60711
Conversation
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Async-loaded Components (~123 bytes added 📈 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
Let's also handle the case when users have already paid for a plan – any paid plan for simple, the business plan for Woo: #60710 (comment) |
I've used a ternary operator inside the component markup because the logic is simple and it seems easy to read.
|
Sure, looks good. 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests Great! I tried three sites: free, Premium, and Business, and got the variations I expected. ✨
Just tidy up the chaining and sort the failed test, then 🚢
…e-requirement-for-simple-option
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/7123738 Thank you @nelsonec87 for including a screenshot in the description! This is really helpful for our translators. |
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/7123738 Thank you @nelsonec87 for including a screenshot in the description! This is really helpful for our translators. |
Translation for this Pull Request has now been finished. |
Changes proposed in this Pull Request
Testing instructions
Access
start/setup-site/intent?siteSlug=<SITE SLUG>&flags=seller-experience
(which enables theseller-experience
feature flag)Click the "Start Selling" button
Click "Continue"
Check the new view
With Free plan:
Paid Plan:
Business or eCommerce plans:
The link should take you to the plans page.
Fixes #60710