phpMyAdmin hosting card: migrate data getter to direct wpcom.req.post

[jsnajdr]

For an Atomic site, there is a /hosting-config/:site page available (accessible also from Settings > Hosting Configuration in sidebar) and it contains a card for opening phpMyAdmin:

How the "Open phpMyAdmin" button works is that it first issues a POST request to public-api to retrieve a token, and then opens a wordpress.com/pma-login?token URL in a new window.

It's the POST request this PR is migrating from a data getter to a simple wpcom.req.post request.

How to test:
Verify that the flow I describe above works for an Atomic site: clicking the button should retrieve a token and open a phpMyAdmin for the site in a new tab.

[github-actions]

Calypso Live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-26672

Jetpack Cloud live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-26672&env=jetpack

[matticbot]

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~35 bytes added 📈 [gzipped])

name        parsed_size           gzip_size
entry-main       -201 B  (-0.0%)      +35 B  (+0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~163 bytes removed 📉 [gzipped])

name     parsed_size           gzip_size
hosting       -274 B  (-0.1%)     -163 B  (-0.1%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

[tyxla]

This looks good to me! Great cleanup! 🚀

I'd only add an error notice in the failure scenario. 🔔

Noting that this can't be fully tested due to the fact that it only works on wordpress.com domain (it's a limitation of the endpoint by design, with security purposes). Let's keep an eye and re-test once it's on staging!

[tyxla]

I think it would be useful if we can just dispatch an error notice in this scenario.

[jsnajdr]

Notice added 👍 It's a very generic "could not open please try again" message because there's nothing that could be comprehensible or actionable for the user. The main goal is to say something instead of failing silently.

[jsnajdr]

this can't be fully tested due to the fact that it only works on wordpress.com domain

Does it really? I was able to test the feature completely on an Atomic site, even in development Calypso. It fetches a token from the REST endpoint and opens wordpress.com/pma-login?token=... in a new window. The /pma-login page is not server by Calypso, it's a PHP-powered wpcom route.

[tyxla]

this can't be fully tested due to the fact that it only works on wordpress.com domain

Does it really? I was able to test the feature completely on an Atomic site, even in development Calypso. It fetches a token from the REST endpoint and opens wordpress.com/pma-login?token=... in a new window. The /pma-login page is not server by Calypso, it's a PHP-powered wpcom route.

It's weird how you managed to test it! Looking at request_phpmyadmin_login() it seems like we are validating the HTTP_HOST on top of the other validations. And when I test with calypso.live on this branch, it doesn't work (it fails silently because of the catch).

[jsnajdr]

It's weird how you managed to test it!

Now I see what's wrong: the server endpoint checks if the origin is in an approved list (A8C\Atomic\Hosting\Utils\validate_api_request function) and the list includes:

http://calypso.localhost:3000
https://calypso.live

I was testing only in local dev server which is OK. But calypso.live containers run on a random subdomain and the origin doesn't match.

When doing a similar origin check at other places (e.g., OAuth code), we "normalize" the calypso.live urls with:

preg_replace( '#^https://[a-z0-9-]+\.calypso\.live(/|$)#', 'https://calypso.live$1', $redirect_uri )

before checking. The validate_api_request function would deserve to have this step, too.

[a8ci18n]

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/7128962

Thank you @jsnajdr for including a screenshot in the description! This is really helpful for our translators.

[a8ci18n]

Translation for this Pull Request has now been finished.