Plugins: Improve messaging for Jetpack Scan detected errors

[epeicher]

When uploading a plugin, it is scanned using Jetpack. The previous message
was unclear, so it has been improved to a more explicit message.

Depends on D74922-code

Changes proposed in this Pull Request

• Change the error message when Jetpack Scan reports a failure from

  Upload problem: Invalid plugin.

  to

  The uploaded file is identified as malicious.

Additionally, the displayed page offers a workaround that reads:

This plugin is identified as malicious. If you want to install the plugin, please continue by uploading the plugin again from WP Admin.

Before	After

Pinging to @emmnyc85 and @cavalierlife to check if the suggested message is fine 🙂

Testing instructions

• Apply D74922-code
• In an Atomic site, go to https://wordpress.com/plugins/upload
• Upload a plugin that fails, for example, this one pdh6GB-6h-p2#comment-698
• The notification message should display The uploaded file is identified as malicious. and the displayed page should contain the message This plugin is identified as malicious. If you want to install the plugin, please continue by uploading the plugin again from WP Admin.. That page will contain two action buttons:
  • Back that will navigate to previous page
  • Continue that will re-direct to the upload plugin from the wp-admin page.

Fixes #58942

[github-actions]

Calypso Live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-27225

Jetpack Cloud live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-27225&env=jetpack

[matticbot]

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~160 bytes added 📈 [gzipped])

name                                 parsed_size           gzip_size
marketplace                               +501 B  (+0.1%)      +86 B  (+0.0%)
woocommerce-installation                   +75 B  (+0.0%)      +24 B  (+0.0%)
themes                                     +75 B  (+0.0%)      +24 B  (+0.0%)
settings-performance                       +75 B  (+0.0%)      +24 B  (+0.0%)
settings                                   +75 B  (+0.0%)      +22 B  (+0.0%)
scan                                       +75 B  (+0.0%)      +24 B  (+0.0%)
plugins                                    +75 B  (+0.0%)      +24 B  (+0.0%)
hosting                                    +75 B  (+0.0%)      +24 B  (+0.0%)
home                                       +75 B  (+0.0%)      +27 B  (+0.0%)
backup                                     +75 B  (+0.0%)      +24 B  (+0.0%)
automated-transfer-state-middleware        +75 B  (+0.4%)      +25 B  (+0.4%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~24 bytes added 📈 [gzipped])

name                                                 parsed_size           gzip_size
async-load-signup-steps-woocommerce-install-confirm        +75 B  (+0.1%)      +24 B  (+0.1%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

[cpapazoglou]

Tested this and works as advertised.

Can we also do the extra mile here by changing the error message in the main content and providing the user an alternative for uploading the plugin through WP Admin?

Prior art here

wp-calypso/client/my-sites/marketplace/pages/marketplace-plugin-install/index.tsx

Lines 336 to 350 in 08c583c

	if ( pluginExists ) {
	return (
	<EmptyContent
	illustration="/calypso/images/illustrations/error.svg"
	title={ null }
	line={ translate(
	'This plugin already exists on your site. If you want to upgrade or downgrade the plugin, please continue by uploading the plugin again from WP Admin.'
	) }
	secondaryAction={ translate( 'Back' ) }
	secondaryActionURL={ `/plugins/upload/${ selectedSiteSlug }` }
	action={ translate( 'Continue' ) }
	actionURL={ `https://${ selectedSiteSlug }/wp-admin/plugin-install.php?tab=upload` }
	/>
	);
	}

[cpapazoglou]

Thanks for addressing the feedback! That's a great improvement in UX!

Just left a minor comment regarding copy.

[a8ci18n]

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/7141787

Thank you @epeicher for including a screenshot in the description! This is really helpful for our translators.

[a8ci18n]

Translation for this Pull Request has now been finished.