Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

My Home: Add Store education card #61586

Merged
merged 5 commits into from Mar 7, 2022
Merged

My Home: Add Store education card #61586

merged 5 commits into from Mar 7, 2022

Conversation

sixhours
Copy link
Contributor

@sixhours sixhours commented Mar 1, 2022 •
edited

Changes proposed in this Pull Request

  • Add a new card component for the store for launched sites with the sell intent
  • Must be run with D75890-code and the API sandboxed

Visual demo

Screen Shot 2022-03-02 at 3 53 36 PM

Testing instructions

  • Switch to this PR, navigate to /home on a launched site that's created through the seller experience flow
  • Apply D75890-code to your sandbox and sandbox public-api.wordpress.com
  • You should see the new "How to set up an online store" card in the educational section of My Home.

Related to #61467

@sixhours sixhours added [Status] In Progress [Feature] My Home The main dashboard for managing a WordPress.com site. [Feature Group] Customer Seller Experience The customer experience when purchasing services or products. labels Mar 1, 2022
@sixhours sixhours requested a review from a team March 1, 2022 21:38
@sixhours sixhours requested a review from a team as a code owner March 1, 2022 21:38
@sixhours sixhours self-assigned this Mar 1, 2022
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Mar 1, 2022
@sixhours sixhours removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Mar 1, 2022
@github-actions
Copy link

github-actions bot commented Mar 1, 2022 •
edited by matticbot

Calypso Live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-28725
Jetpack Cloud live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-28725&env=jetpack

@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Mar 1, 2022
@matticbot
Copy link
Contributor

matticbot commented Mar 1, 2022 •
edited

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~179 bytes added 📈 [gzipped])

name  parsed_size           gzip_size
home       +663 B  (+0.1%)     +179 B  (+0.1%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@blackjackkent
Copy link
Contributor

Behaviorally this looks great - however, the requirements for the issue state we need to display this specifically for users with the "sell" intent. It doesn't look like we're checking for that right now; is that intended for a future PR?

@sixhours
Copy link
Contributor Author

sixhours commented Mar 2, 2022

Behaviorally this looks great - however, the requirements for the issue state we need to display this specifically for users with the "sell" intent. It doesn't look like we're checking for that right now; is that intended for a future PR?

Aha, I missed that! I will fix that, as well as updating the illustration to use the correct one :)

@sixhours sixhours changed the title My Home: Begin adding Store education card My Home: Add Store education card Mar 2, 2022
@sixhours
Copy link
Contributor Author

sixhours commented Mar 2, 2022

@blackjackkent I updated the server-side diff to add a check for the intent before displaying the card!

sixhours
sixhours commented Mar 2, 2022
View reviewed changes
client/my-sites/customer-home/cards/education/store/index.jsx
links={ [
{
externalLink: true,
url: `https://wordpress.com/support/video-tutorials-add-payments-features-to-your-site-with-our-guides/`,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may need localizeUrl, need to double check.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this content hasn't been translated to other languages yet.

@andres-blanco
Copy link
Contributor

added a comment on D75890-code

@sixhours sixhours force-pushed the add/customer-education-store-card branch from 4e82145 to 69a3a30 Compare March 7, 2022 18:21
andres-blanco
andres-blanco approved these changes Mar 7, 2022
View reviewed changes
Copy link
Contributor

@andres-blanco andres-blanco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Remember to merge this AFTER D75890-code

image

@sixhours sixhours merged commit dba16a0 into trunk Mar 7, 2022
@sixhours sixhours deleted the add/customer-education-store-card branch March 7, 2022 19:08
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Mar 7, 2022
@sixhours sixhours mentioned this pull request Mar 7, 2022
Closed
@a8ci18n
Copy link

a8ci18n commented Mar 7, 2022

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/7171556

Thank you @sixhours for including a screenshot in the description! This is really helpful for our translators.

@a8ci18n
Copy link

a8ci18n commented Mar 18, 2022

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andres-blanco andres-blanco andres-blanco approved these changes

Assignees

@sixhours sixhours

Labels
[Feature Group] Customer Seller Experience The customer experience when purchasing services or products. [Feature] My Home The main dashboard for managing a WordPress.com site.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@sixhours @matticbot @blackjackkent @andres-blanco @a8ci18n