Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seller-experience: Adding new Payments block step #61771

Merged
merged 3 commits into from
Mar 18, 2022

Conversation

nelsonec87
Copy link
Contributor

Changes proposed in this Pull Request

  • Add new 'Payment block' step to editor welcome tour

Testing instructions

To see the new step:

  • Sync calypso's editing-toolkit app to your sandbox
  • Sandbox a new site url
  • Create this new site using the simple seller flow
  • Its editor should open on the end of the flow https://wordpress.com/site-editor/<your-site>
  • There should be a "Payments block" step (the second-to-last step)
  • If you follow any other flow, you shouldn't get the Payments step.

image

Closes #61466

@nelsonec87 nelsonec87 requested a review from a team as a code owner March 9, 2022 16:45
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Mar 9, 2022
@github-actions
Copy link

github-actions bot commented Mar 9, 2022

@matticbot
Copy link
Contributor

This PR modifies the release build for editing-toolkit

To test your changes on WordPress.com, run install-plugin.sh editing-toolkit add/payments-block-step-to-tour on your sandbox.

To deploy your changes after merging, see the documentation: PCYsg-mMA-p2

@nelsonec87 nelsonec87 changed the title Adding new Payments block step Seller-experience: Adding new Payments block step Mar 9, 2022
@nelsonec87 nelsonec87 requested a review from a team March 9, 2022 16:54
@nelsonec87 nelsonec87 self-assigned this Mar 9, 2022
@nelsonec87 nelsonec87 added the [Feature Group] Customer Seller Experience The customer experience when purchasing services or products. label Mar 9, 2022
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@nelsonec87 nelsonec87 changed the title Seller-experience: Adding new Payments block step [WIP] Seller-experience: Adding new Payments block step Mar 9, 2022
@kwight
Copy link
Contributor

kwight commented Mar 14, 2022

Looks good, showed up for me. 👍 (I also checked Build and Write, neither of them showed the card.)

Screen Shot 2022-03-14 at 1 25 34 PM

Copy link
Contributor

@blackjackkent blackjackkent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know we were waiting on a gif from @vinimotaa here but let's go ahead and get the general change merged in and we can update the image in a follow-up PR.

@nelsonec87 nelsonec87 merged commit 917833f into trunk Mar 18, 2022
@nelsonec87 nelsonec87 deleted the add/payments-block-step-to-tour branch March 18, 2022 13:08
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Mar 18, 2022
@nelsonec87 nelsonec87 changed the title [WIP] Seller-experience: Adding new Payments block step Seller-experience: Adding new Payments block step Mar 18, 2022
@a8ci18n
Copy link

a8ci18n commented Mar 18, 2022

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/7188688

Thank you @nelsonec87 for including a screenshot in the description! This is really helpful for our translators.

@a8ci18n
Copy link

a8ci18n commented Mar 24, 2022

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature Group] Customer Seller Experience The customer experience when purchasing services or products.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Seller Experience - Add a new Seller-related step to the editor welcome tour
5 participants