Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plans overhaul Phase 1: Rename Managed plan to Pro on Plan grid #61958

Merged
merged 3 commits into from
Mar 16, 2022
Merged

Plans overhaul Phase 1: Rename Managed plan to Pro on Plan grid #61958

merged 3 commits into from
Mar 16, 2022

Conversation

claudiucelfilip
Copy link
Contributor

Changes proposed in this Pull Request

More context: pdgrnI-tm-p2

This renames any Managed plan-related items to match the WordPress Pro naming.

Testing instructions

  • Go to /star/plans?flags=plans/pro-plan
  • You should see the overhauled Plans with the Free and Pro plans

Screenshot on 2022-03-15 at 16-14-15

  • While on a Free Plan site, go to /plans/[site]?flags=plans/pro-plan
  • You should see the overhauled Plans with the Free and Pro plans.
    NOTE: The Pro plan may have a price of 0. This should show the proper once the DB has been updated with the new product slug for the Pro Plan.

Screenshot on 2022-03-15 at 16-14-58

  • Double-check that the legacy Plans on /star/plans and /plans/[site] (without the flag param) are unaffected.

@claudiucelfilip claudiucelfilip self-assigned this Mar 15, 2022
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Mar 15, 2022
@github-actions
Copy link

github-actions bot commented Mar 15, 2022 •
edited by matticbot
Loading

Calypso Live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-29362
Jetpack Cloud live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-29362&env=jetpack

@matticbot
Copy link
Contributor

matticbot commented Mar 15, 2022 •
edited
Loading

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~127 bytes removed 📉 [gzipped])

name                      parsed_size           gzip_size
plans                           -75 B  (-0.0%)      +10 B  (+0.0%)
woocommerce-installation        +69 B  (+0.0%)      +10 B  (+0.0%)
themes                          +69 B  (+0.0%)       +9 B  (+0.0%)
theme                           +69 B  (+0.0%)      +10 B  (+0.0%)
stats                           +69 B  (+0.0%)      +10 B  (+0.0%)
site-purchases                  +69 B  (+0.0%)      +11 B  (+0.0%)
settings-writing                +69 B  (+0.0%)      +12 B  (+0.0%)
settings-security               +69 B  (+0.0%)      +10 B  (+0.0%)
settings-performance            +69 B  (+0.0%)       +8 B  (+0.0%)
settings-jetpack                +69 B  (+0.0%)      +10 B  (+0.0%)
settings                        +69 B  (+0.0%)      +10 B  (+0.0%)
scan                            +69 B  (+0.0%)       +9 B  (+0.0%)
purchases                       +69 B  (+0.0%)      +11 B  (+0.0%)
purchase-product                +69 B  (+0.0%)      +10 B  (+0.0%)
posts-custom                    +69 B  (+0.0%)      +10 B  (+0.0%)
posts                           +69 B  (+0.0%)      +10 B  (+0.0%)
people                          +69 B  (+0.0%)      +10 B  (+0.0%)
migrate                         +69 B  (+0.0%)       +9 B  (+0.0%)
media                           +69 B  (+0.0%)      +10 B  (+0.0%)
marketing                       +69 B  (+0.0%)      +12 B  (+0.0%)
jetpack-search                  +69 B  (+0.0%)      +11 B  (+0.0%)
jetpack-cloud-pricing           +69 B  (+0.0%)      +10 B  (+0.0%)
hosting                         +69 B  (+0.0%)       +9 B  (+0.0%)
help                            +69 B  (+0.0%)      +12 B  (+0.0%)
google-my-business              +69 B  (+0.0%)      +12 B  (+0.0%)
email                           +69 B  (+0.0%)      +10 B  (+0.0%)
earn                            +69 B  (+0.0%)       +9 B  (+0.0%)
comments                        +69 B  (+0.0%)      +10 B  (+0.0%)
backup                          +69 B  (+0.0%)       +9 B  (+0.0%)
activity                        +69 B  (+0.0%)      +10 B  (+0.0%)
account-close                   +69 B  (+0.0%)       +9 B  (+0.0%)
plugins                         +65 B  (+0.0%)      +11 B  (+0.0%)
marketplace                     +61 B  (+0.0%)       +8 B  (+0.0%)
domains                         +61 B  (+0.0%)       +8 B  (+0.0%)
checkout                        +61 B  (+0.0%)       +8 B  (+0.0%)
signup                          +45 B  (+0.0%)       +2 B  (+0.0%)
jetpack-connect                 +45 B  (+0.0%)       +2 B  (+0.0%)
accept-invite                   +45 B  (+0.0%)       +3 B  (+0.0%)
gutenberg-editor                -12 B  (-0.0%)       -6 B  (-0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~47 bytes removed 📉 [gzipped])

name                                                              parsed_size           gzip_size
async-load-signup-steps-plans                                          -112 B  (-0.0%)       +3 B  (+0.0%)
async-load-calypso-post-editor-editor-media-modal                       +73 B  (+0.0%)      +16 B  (+0.0%)
async-load-calypso-blocks-editor-checkout-modal                         +73 B  (+0.0%)      +16 B  (+0.0%)
async-load-masterbar-cart-masterbar-cart-wrapper                        +69 B  (+0.0%)      +11 B  (+0.0%)
async-load-design-playground                                            +69 B  (+0.0%)       +9 B  (+0.0%)
async-load-design-blocks                                                +69 B  (+0.0%)      +11 B  (+0.0%)
async-load-design                                                       +69 B  (+0.0%)       +9 B  (+0.0%)
async-load-calypso-reader-sidebar                                       +69 B  (+0.1%)      +12 B  (+0.0%)
async-load-calypso-my-sites-current-site-stale-cart-items-notice        +69 B  (+0.1%)      +11 B  (+0.1%)
async-load-calypso-my-sites-current-site-notice                         +69 B  (+0.1%)      +10 B  (+0.0%)
async-load-calypso-components-web-preview-component                     +69 B  (+0.0%)      +11 B  (+0.0%)
async-load-calypso-blocks-jitm-templates-sidebar-banner                 +69 B  (+0.1%)      +11 B  (+0.1%)
async-load-calypso-blocks-jitm-templates-notice                         +69 B  (+0.1%)      +11 B  (+0.1%)
async-load-calypso-blocks-jitm-templates-default                        +69 B  (+0.1%)      +10 B  (+0.0%)
async-load-calypso-blocks-inline-help-popover                           +69 B  (+0.0%)      +12 B  (+0.0%)
async-load-calypso-blocks-product-purchase-features-list                -12 B  (-0.0%)       -3 B  (-0.0%)
async-load-calypso-blocks-app-banner                                    -12 B  (-0.0%)       -6 B  (-0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

DavidRothstein
DavidRothstein reviewed Mar 15, 2022
View reviewed changes
client/my-sites/plans-comparison/plans-comparison-features.tsx Outdated
description: translate(
'The free plan allows a maximum storage of 500MB, which equals to approximately 100 high quality images, whilst with Managed WordPress you may go all the way up to 50GB, enough space for 10,000 high quality images of the same size.'
'The free plan allows a maximum storage of 500MB, which equals to approximately 100 high quality images, whilst with Pro you may go all the way up to 50GB, enough space for 10,000 high quality images of the same size.'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe change "whilst" to "while" here also (since this is already going to need to be re-translated, and it's better not to have to re-translate it again later)?

As far as I know, the base text in Calypso should always be using American English, given that there is a separate language option for British English, and in theory the "translators" could use "whilst" for that one if they wanted 😄

Screenshot from 2022-03-15 10-48-45

@DavidRothstein DavidRothstein mentioned this pull request Mar 15, 2022
Merged
@matticbot
Copy link
Contributor

This PR modifies the release build for notifications

To test your changes on WordPress.com, run install-plugin.sh notifications update/managed-plan-rename on your sandbox.

To deploy your changes after merging, see the documentation: PCYsg-elI-p2

@matticbot
Copy link
Contributor

This PR modifies the release build for wpcom-block-editor

To test your changes on WordPress.com, run install-plugin.sh wpcom-block-editor update/managed-plan-rename on your sandbox.

To deploy your changes after merging, see the documentation: PCYsg-l4k-p2

southp
southp approved these changes Mar 16, 2022
View reviewed changes
Copy link
Contributor

@southp southp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've gone through a few flows and they all works as expected:

  • Purchase a Pro plan and refund
  • Create a new
  • Create a legacy plan user and go through the plan page with/without the flag.

The code also LGTM 🚢

@claudiucelfilip claudiucelfilip merged commit 4015697 into trunk Mar 16, 2022
@claudiucelfilip claudiucelfilip deleted the update/managed-plan-rename branch March 16, 2022 10:57
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Mar 16, 2022
@a8ci18n
Copy link

a8ci18n commented Mar 16, 2022

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/7183462

Thank you @claudiucelfilip for including a screenshot in the description! This is really helpful for our translators.

@a8ci18n
Copy link

a8ci18n commented Mar 24, 2022

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavidRothstein DavidRothstein DavidRothstein left review comments

@southp southp southp approved these changes

@dzver dzver Awaiting requested review from dzver

@gmovr gmovr Awaiting requested review from gmovr

Assignees

@claudiucelfilip claudiucelfilip

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@claudiucelfilip @matticbot @a8ci18n @DavidRothstein @southp