Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plans overhaul Phase 1: Apply latest copy and design to Plans pages #62010

Merged
merged 5 commits into from
Mar 18, 2022
Merged

Plans overhaul Phase 1: Apply latest copy and design to Plans pages #62010

merged 5 commits into from
Mar 18, 2022

Conversation

claudiucelfilip
Copy link
Contributor

@claudiucelfilip claudiucelfilip commented Mar 17, 2022 •
edited
Loading

Changes proposed in this Pull Request

More info: pdgrnI-pJ#comment-768-p2

  • adds the latest copy to the overhauled Plan grid
  • enables new Plan grid for Atomic sites
  • adjusts mobile layout sizes

Planning page i1 - collapsed - final copy VERSION2

Testing instructions

  • Go to /plans/[site]/?flags=plans/pro-plan
  • The Plans grid copy should match the design from the description
  • Feature tooltip popup text should match the ones from the spreadsheet: 2bf68-pb

Screenshot 2022-03-17 at 14 49 34

Screenshot 2022-03-17 at 14 50 37

  • Go to /start/plans?flags=plans/pro-plan
  • The Plans page should match the design from the description

Screenshot 2022-03-17 at 14 52 08

Screenshot 2022-03-17 at 14 52 23

  • Go to /plans/my-plan/[site]?flags=plans/pro-plan on an Atomic site (ex. Bussiness)
  • You should notice the Plan overhaul changes

Screenshot 2022-03-17 at 15 14 03

@claudiucelfilip claudiucelfilip self-assigned this Mar 17, 2022
@github-actions
Copy link

github-actions bot commented Mar 17, 2022 •
edited by matticbot
Loading

Calypso Live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-29583
Jetpack Cloud live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-29583&env=jetpack

@matticbot
Copy link
Contributor

matticbot commented Mar 17, 2022 •
edited
Loading

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~728 bytes added 📈 [gzipped])

name                      parsed_size           gzip_size
plans                         +3162 B  (+0.4%)     +728 B  (+0.3%)
woocommerce-installation        +79 B  (+0.0%)      +32 B  (+0.0%)
themes                          +79 B  (+0.0%)      +32 B  (+0.0%)
theme                           +79 B  (+0.0%)      +32 B  (+0.0%)
stats                           +79 B  (+0.0%)      +32 B  (+0.0%)
site-purchases                  +79 B  (+0.0%)      +32 B  (+0.0%)
signup                          +79 B  (+0.0%)      +32 B  (+0.0%)
settings-writing                +79 B  (+0.0%)      +32 B  (+0.0%)
settings-security               +79 B  (+0.0%)      +32 B  (+0.0%)
settings-performance            +79 B  (+0.0%)      +32 B  (+0.0%)
settings-jetpack                +79 B  (+0.0%)      +32 B  (+0.0%)
settings                        +79 B  (+0.0%)      +32 B  (+0.0%)
scan                            +79 B  (+0.0%)      +32 B  (+0.0%)
purchases                       +79 B  (+0.0%)      +32 B  (+0.0%)
purchase-product                +79 B  (+0.0%)      +32 B  (+0.1%)
posts-custom                    +79 B  (+0.0%)      +32 B  (+0.0%)
posts                           +79 B  (+0.0%)      +32 B  (+0.0%)
plugins                         +79 B  (+0.0%)      +32 B  (+0.0%)
people                          +79 B  (+0.0%)      +32 B  (+0.0%)
migrate                         +79 B  (+0.0%)      +32 B  (+0.0%)
media                           +79 B  (+0.0%)      +32 B  (+0.0%)
marketplace                     +79 B  (+0.0%)      +32 B  (+0.0%)
marketing                       +79 B  (+0.0%)      +32 B  (+0.0%)
jetpack-search                  +79 B  (+0.0%)      +32 B  (+0.0%)
jetpack-connect                 +79 B  (+0.0%)      +32 B  (+0.0%)
jetpack-cloud-pricing           +79 B  (+0.0%)      +32 B  (+0.0%)
hosting                         +79 B  (+0.0%)      +32 B  (+0.0%)
help                            +79 B  (+0.0%)      +32 B  (+0.0%)
google-my-business              +79 B  (+0.0%)      +32 B  (+0.0%)
email                           +79 B  (+0.0%)      +32 B  (+0.0%)
earn                            +79 B  (+0.0%)      +32 B  (+0.0%)
domains                         +79 B  (+0.0%)      +32 B  (+0.0%)
comments                        +79 B  (+0.0%)      +32 B  (+0.0%)
checkout                        +79 B  (+0.0%)      +32 B  (+0.0%)
backup                          +79 B  (+0.0%)      +32 B  (+0.0%)
activity                        +79 B  (+0.0%)      +32 B  (+0.0%)
account-close                   +79 B  (+0.0%)      +32 B  (+0.0%)
accept-invite                   +79 B  (+0.0%)      +32 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~724 bytes added 📈 [gzipped])

name                                                              parsed_size           gzip_size
async-load-signup-steps-plans                                         +3110 B  (+1.0%)     +692 B  (+0.8%)
async-load-masterbar-cart-masterbar-cart-wrapper                        +79 B  (+0.1%)      +32 B  (+0.1%)
async-load-design-playground                                            +79 B  (+0.0%)      +32 B  (+0.0%)
async-load-design-blocks                                                +79 B  (+0.0%)      +32 B  (+0.0%)
async-load-design                                                       +79 B  (+0.0%)      +32 B  (+0.0%)
async-load-calypso-reader-sidebar                                       +79 B  (+0.1%)      +32 B  (+0.1%)
async-load-calypso-post-editor-editor-media-modal                       +79 B  (+0.0%)      +32 B  (+0.0%)
async-load-calypso-my-sites-current-site-stale-cart-items-notice        +79 B  (+0.1%)      +32 B  (+0.2%)
async-load-calypso-my-sites-current-site-notice                         +79 B  (+0.1%)      +32 B  (+0.1%)
async-load-calypso-components-web-preview-component                     +79 B  (+0.0%)      +32 B  (+0.0%)
async-load-calypso-blocks-jitm-templates-sidebar-banner                 +79 B  (+0.1%)      +32 B  (+0.2%)
async-load-calypso-blocks-jitm-templates-notice                         +79 B  (+0.1%)      +32 B  (+0.2%)
async-load-calypso-blocks-jitm-templates-default                        +79 B  (+0.1%)      +32 B  (+0.2%)
async-load-calypso-blocks-inline-help-popover                           +79 B  (+0.0%)      +32 B  (+0.0%)
async-load-calypso-blocks-editor-checkout-modal                         +79 B  (+0.0%)      +32 B  (+0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@matticbot
Copy link
Contributor

This PR modifies the release build for wpcom-block-editor

To test your changes on WordPress.com, run install-plugin.sh wpcom-block-editor update/plans-overhaul-latest-copy-design on your sandbox.

To deploy your changes after merging, see the documentation: PCYsg-l4k-p2

@matticbot
Copy link
Contributor

This PR modifies the release build for notifications

To test your changes on WordPress.com, run install-plugin.sh notifications update/plans-overhaul-latest-copy-design on your sandbox.

To deploy your changes after merging, see the documentation: PCYsg-elI-p2

@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Mar 17, 2022
@claudiucelfilip
Copy link
Contributor Author

Apply the final copy changes for the Calypso Plans

@southp
Copy link
Contributor

southp commented Mar 17, 2022

Test comment 2

@dzver
Copy link
Member

dzver commented Mar 17, 2022

(I seem to have issues posting a comment or uploading files)

There's a small misalignment on Desktop that I see, is this on purpose?

Screenshot 2022-03-17 at 16 25 56

southp
southp approved these changes Mar 18, 2022
View reviewed changes
Copy link
Contributor

@southp southp left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's now perfectly aligned. LGTM :)
image

@claudiucelfilip claudiucelfilip added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Mar 18, 2022
@claudiucelfilip claudiucelfilip merged commit 5e1ad4d into trunk Mar 18, 2022
@claudiucelfilip claudiucelfilip deleted the update/plans-overhaul-latest-copy-design branch March 18, 2022 08:26
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Mar 18, 2022
@a8ci18n
Copy link

a8ci18n commented Mar 18, 2022

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/7187250

Thank you @claudiucelfilip for including a screenshot in the description! This is really helpful for our translators.

1 similar comment
@a8ci18n
Copy link

a8ci18n commented Mar 24, 2022 •
edited
Loading

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/7187250

Thank you @claudiucelfilip for including a screenshot in the description! This is really helpful for our translators.

@a8ci18n
Copy link

a8ci18n commented Apr 11, 2022

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@southp southp southp approved these changes

@dzver dzver Awaiting requested review from dzver

@gmovr gmovr Awaiting requested review from gmovr

Assignees

@claudiucelfilip claudiucelfilip

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@claudiucelfilip @matticbot @southp @dzver @a8ci18n