Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Users already on Pro are being asked to upgrade to Pro for two Earn features #62376

Merged
merged 2 commits into from
Mar 30, 2022
Merged

Users already on Pro are being asked to upgrade to Pro for two Earn features #62376

merged 2 commits into from
Mar 30, 2022

Conversation

claudiucelfilip
Copy link
Contributor

@claudiucelfilip claudiucelfilip commented Mar 30, 2022 •
edited

Changes proposed in this Pull Request

This adds the two Earn Features to the Pro plan config and updates the related card copies to mention Pro plan.

Testing instructions

  • Go to /earn/[site]?flags=plans/pro-plan on a Free site
  • The "Collect PayPal payments" and "Earn ad revenue" should show the Unlock this Feature buttons .

Screenshot on 2022-03-30 at 11-55-09

  • Go to /earn/[site]?flags=plans/pro-plan on a Pro site
  • The "Collect PayPal payments" and "Earn ad revenue" should be unlocked

Screenshot on 2022-03-30 at 12-01-22

@claudiucelfilip claudiucelfilip self-assigned this Mar 30, 2022
@github-actions
Copy link

github-actions bot commented Mar 30, 2022 •
edited by matticbot

Calypso Live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-30258
Jetpack Cloud live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-30258&env=jetpack

@claudiucelfilip
Copy link
Contributor Author

Users already on Pro are being asked to upgrade to Pro for two Earn features

@matticbot
Copy link
Contributor

matticbot commented Mar 30, 2022 •
edited

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~32 bytes added 📈 [gzipped])

name                   parsed_size           gzip_size
entry-main                  +169 B  (+0.0%)      +29 B  (+0.0%)
entry-stepper               +137 B  (+0.0%)      +20 B  (+0.0%)
entry-login                 +126 B  (+0.0%)      +17 B  (+0.0%)
entry-gutenboarding         +126 B  (+0.0%)      +17 B  (+0.0%)
entry-domains-landing       +126 B  (+0.0%)      +17 B  (+0.0%)
entry-browsehappy           +126 B  (+0.1%)      +17 B  (+0.1%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~8808 bytes added 📈 [gzipped])

name                      parsed_size           gzip_size
earn                         +27823 B  (+5.8%)    +7752 B  (+5.5%)
woocommerce-installation        +11 B  (+0.0%)       +3 B  (+0.0%)
themes                          +11 B  (+0.0%)       +3 B  (+0.0%)
theme                           +11 B  (+0.0%)       +3 B  (+0.0%)
stats                           +11 B  (+0.0%)       +3 B  (+0.0%)
site-purchases                  +11 B  (+0.0%)       +3 B  (+0.0%)
signup                          +11 B  (+0.0%)       +3 B  (+0.0%)
settings-writing                +11 B  (+0.0%)       +3 B  (+0.0%)
settings-security               +11 B  (+0.0%)       +3 B  (+0.0%)
settings-performance            +11 B  (+0.0%)       +3 B  (+0.0%)
settings                        +11 B  (+0.0%)       +3 B  (+0.0%)
scan                            +11 B  (+0.0%)       +3 B  (+0.0%)
purchases                       +11 B  (+0.0%)       +3 B  (+0.0%)
purchase-product                +11 B  (+0.0%)       +3 B  (+0.0%)
posts-custom                    +11 B  (+0.0%)       +3 B  (+0.0%)
posts                           +11 B  (+0.0%)       +3 B  (+0.0%)
plugins                         +11 B  (+0.0%)       +3 B  (+0.0%)
plans                           +11 B  (+0.0%)       +3 B  (+0.0%)
people                          +11 B  (+0.0%)       +3 B  (+0.0%)
migrate                         +11 B  (+0.0%)       +3 B  (+0.0%)
media                           +11 B  (+0.0%)       +3 B  (+0.0%)
marketplace                     +11 B  (+0.0%)       +3 B  (+0.0%)
marketing                       +11 B  (+0.0%)       +3 B  (+0.0%)
jetpack-search                  +11 B  (+0.0%)       +3 B  (+0.0%)
jetpack-connect                 +11 B  (+0.0%)       +3 B  (+0.0%)
jetpack-cloud-pricing           +11 B  (+0.0%)       +3 B  (+0.0%)
hosting                         +11 B  (+0.0%)       +3 B  (+0.0%)
home                            +11 B  (+0.0%)       +3 B  (+0.0%)
help                            +11 B  (+0.0%)       +3 B  (+0.0%)
google-my-business              +11 B  (+0.0%)       +3 B  (+0.0%)
email                           +11 B  (+0.0%)       +3 B  (+0.0%)
domains                         +11 B  (+0.0%)       +3 B  (+0.0%)
comments                        +11 B  (+0.0%)       +3 B  (+0.0%)
checkout                        +11 B  (+0.0%)       +3 B  (+0.0%)
backup                          +11 B  (+0.0%)       +3 B  (+0.0%)
activity                        +11 B  (+0.0%)       +3 B  (+0.0%)
account-close                   +11 B  (+0.0%)       +3 B  (+0.0%)
accept-invite                   +11 B  (+0.0%)       +3 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~3 bytes added 📈 [gzipped])

name                                                              parsed_size           gzip_size
async-load-masterbar-cart-masterbar-cart-wrapper                        +11 B  (+0.0%)       +3 B  (+0.0%)
async-load-design-playground                                            +11 B  (+0.0%)       +3 B  (+0.0%)
async-load-design-blocks                                                +11 B  (+0.0%)       +3 B  (+0.0%)
async-load-design                                                       +11 B  (+0.0%)       +3 B  (+0.0%)
async-load-calypso-reader-sidebar                                       +11 B  (+0.0%)       +3 B  (+0.0%)
async-load-calypso-post-editor-editor-media-modal                       +11 B  (+0.0%)       +3 B  (+0.0%)
async-load-calypso-my-sites-current-site-stale-cart-items-notice        +11 B  (+0.0%)       +3 B  (+0.0%)
async-load-calypso-my-sites-current-site-notice                         +11 B  (+0.0%)       +3 B  (+0.0%)
async-load-calypso-components-web-preview-component                     +11 B  (+0.0%)       +3 B  (+0.0%)
async-load-calypso-blocks-jitm-templates-sidebar-banner                 +11 B  (+0.0%)       +3 B  (+0.0%)
async-load-calypso-blocks-jitm-templates-notice                         +11 B  (+0.0%)       +3 B  (+0.0%)
async-load-calypso-blocks-jitm-templates-default                        +11 B  (+0.0%)       +3 B  (+0.0%)
async-load-calypso-blocks-inline-help-popover                           +11 B  (+0.0%)       +3 B  (+0.0%)
async-load-calypso-blocks-editor-checkout-modal                         +11 B  (+0.0%)       +3 B  (+0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Mar 30, 2022
southp
southp approved these changes Mar 30, 2022
View reviewed changes
Copy link
Contributor

@southp southp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works as described in the test plan. LGTM 🚢

chriskmnds
chriskmnds approved these changes Mar 30, 2022
View reviewed changes
Copy link
Contributor

@chriskmnds chriskmnds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed as per testing instructions. LGTM

Go to /earn/[site]?flags=plans/pro-plan on a Pro site
The "Collect PayPal payments" and "Earn ad revenue" should be unlocked

This is the same without the query string (?flags=plans/pro-plan)

packages/calypso-products/src/plans-list.tsx
Comment on lines +1622 to +1623
FEATURE_SIMPLE_PAYMENTS,
FEATURE_WORDADS_INSTANT,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why these are needed, but guessing they are necessary :-)

@claudiucelfilip claudiucelfilip merged commit 28d9a0e into trunk Mar 30, 2022
@claudiucelfilip claudiucelfilip deleted the update/pro-plan-add-earn-feature branch March 30, 2022 13:11
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Mar 30, 2022
markbiek pushed a commit that referenced this pull request Mar 30, 2022
@claudiucelfilip @markbiek
Users already on Pro are being asked to upgrade to Pro for two Earn f…
0ca4832 
…eatures (#62376)

* Include the relevant earn feature for the Pro plan and update related copy

* Include the Pro plan in the Premium or Better check
@a8ci18n
Copy link

a8ci18n commented Mar 30, 2022

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/7212193

Thank you @claudiucelfilip for including a screenshot in the description! This is really helpful for our translators.

@a8ci18n
Copy link

a8ci18n commented Apr 8, 2022

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chriskmnds chriskmnds chriskmnds approved these changes

@southp southp southp approved these changes

@DavidRothstein DavidRothstein Awaiting requested review from DavidRothstein

@dzver dzver Awaiting requested review from dzver

Assignees

@claudiucelfilip claudiucelfilip

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@claudiucelfilip @matticbot @a8ci18n @chriskmnds @southp