Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fallback untranslated title, subtitle and plan CTA copy #62402

Merged
merged 1 commit into from Mar 31, 2022

Conversation

claudiucelfilip
Copy link
Contributor

Changes proposed in this Pull Request

This ensures that the copy changes from #62331 fall back to the previous version until they're translated.

Testing instructions

  • On an english locale account
  • Go to /start/plans?flags=plans/pro-plan and to plans/my-plan/[free_site]?flags=plans/pro-plan
  • The title, subtitle and Pro plan CTA copy should match the summary from Update title, subtitle and plab CTA copy #62331:

Markup 2022-03-29 at 12 53 58

  • Change the account to a non-english locale
  • Go to /start/plans?flags=plans/pro-plan and to plans/my-plan/[free_site]?flags=plans/pro-plan
  • The title, subtitle and Pro plan CTA copy should be translated from the previous copy:

Screenshot on 2022-03-31 at 12-38-53

@claudiucelfilip claudiucelfilip self-assigned this Mar 31, 2022
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Mar 31, 2022
@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~38 bytes added 📈 [gzipped])

name                  parsed_size           gzip_size
themes                      +90 B  (+0.0%)      +38 B  (+0.0%)
settings-performance        +90 B  (+0.0%)      +38 B  (+0.0%)
scan                        +90 B  (+0.0%)      +38 B  (+0.0%)
plugins                     +90 B  (+0.0%)      +38 B  (+0.0%)
plans                       +90 B  (+0.0%)      +38 B  (+0.0%)
media                       +90 B  (+0.0%)      +38 B  (+0.0%)
marketplace                 +90 B  (+0.0%)      +38 B  (+0.0%)
hosting                     +90 B  (+0.0%)      +38 B  (+0.0%)
home                        +90 B  (+0.0%)      +38 B  (+0.0%)
earn                        +90 B  (+0.0%)      +38 B  (+0.0%)
domains                     +90 B  (+0.0%)      +38 B  (+0.0%)
checkout                    +90 B  (+0.0%)      +38 B  (+0.0%)
backup                      +90 B  (+0.0%)      +38 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~117 bytes added 📈 [gzipped])

name                                               parsed_size           gzip_size
async-load-signup-steps-plans                           +425 B  (+0.1%)     +117 B  (+0.1%)
async-load-signup-steps-domains                          +90 B  (+0.0%)      +38 B  (+0.0%)
async-load-design-blocks                                 +90 B  (+0.0%)      +38 B  (+0.0%)
async-load-calypso-post-editor-media-modal               +90 B  (+0.0%)      +38 B  (+0.0%)
async-load-calypso-post-editor-editor-media-modal        +90 B  (+0.0%)      +38 B  (+0.0%)
async-load-calypso-my-sites-checkout-modal               +90 B  (+0.0%)      +38 B  (+0.0%)
async-load-calypso-blocks-editor-checkout-modal          +90 B  (+0.0%)      +38 B  (+0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@gmovr gmovr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in Spanish and works as described. LGTM! 🚀
Screenshot 2022-03-31 at 13 12 31

@claudiucelfilip claudiucelfilip merged commit 23d6259 into trunk Mar 31, 2022
@claudiucelfilip claudiucelfilip deleted the update/wrap-new-header-cta-plans-copy branch March 31, 2022 13:42
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Mar 31, 2022
@a8ci18n
Copy link

a8ci18n commented Mar 31, 2022

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/7213472

Thank you @claudiucelfilip for including a screenshot in the description! This is really helpful for our translators.

@a8ci18n
Copy link

a8ci18n commented Apr 8, 2022

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants