New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add marketplace CTA on /marketing/tools #62789
Conversation
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~0 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
c568c43
to
baa0562
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cta needs to link to the marketplace
Fixed! |
Looks good, lets wait for translation to come through, not sure how much benefit there is deploying this early. |
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/7230444 Thank you @lupus2k for including a screenshot in the description! This is really helpful for our translators. |
There is any alternative to merge this and show them to the user when the translations come through ? maybe using some feature flag? just thinking out loud. |
There is a hasTranslate method in i18n-calypso but it's usage is quite clunky and nobody ever cleans them up so I don't really suggest it. |
Translation for this Pull Request has now been finished. |
Changes proposed in this Pull Request
Adjust CTA on /marketing/tools to focus on premium plugins, and link to the Marketplace.
Testing instructions
Screenshots
Related to #62308