Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add marketplace CTA on /marketing/tools #62789

Merged
merged 4 commits into from Apr 28, 2022
Merged

Conversation

lupus2k
Copy link
Contributor

@lupus2k lupus2k commented Apr 14, 2022

Changes proposed in this Pull Request

Adjust CTA on /marketing/tools to focus on premium plugins, and link to the Marketplace.

Testing instructions

  • Go to /marketing/tools and see if matches the design and text

Screenshots

image

Related to #62308

@lupus2k lupus2k self-assigned this Apr 14, 2022
@matticbot
Copy link
Contributor

matticbot commented Apr 14, 2022

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~0 bytes added 📈 [gzipped])

name       parsed_size           gzip_size
marketing        -36 B  (-0.0%)       +0 B

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@lupus2k lupus2k force-pushed the update/marketplace-cta-on-tools branch from c568c43 to baa0562 Compare April 19, 2022 19:30
@lupus2k lupus2k marked this pull request as ready for review April 19, 2022 19:34
@lupus2k lupus2k added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Status] Ready to Merge labels Apr 19, 2022
@lupus2k lupus2k requested review from vinimotaa, a team and emmnyc85 April 19, 2022 19:37
Copy link
Contributor

@Rolilink Rolilink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cta needs to link to the marketplace

@lupus2k
Copy link
Contributor Author

lupus2k commented Apr 19, 2022

cta needs to link to the marketplace

Fixed!

@lupus2k lupus2k requested a review from Rolilink April 19, 2022 22:18
@lsl lsl added the [Status] String Freeze Add the [Status] String Freeze label to your PR to ensure new strings are translated before merging label Apr 20, 2022
@lsl
Copy link
Contributor

lsl commented Apr 20, 2022

Looks good, lets wait for translation to come through, not sure how much benefit there is deploying this early.

@a8ci18n
Copy link

a8ci18n commented Apr 20, 2022

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/7230444

Thank you @lupus2k for including a screenshot in the description! This is really helpful for our translators.

@Rolilink
Copy link
Contributor

Looks good, lets wait for translation to come through, not sure how much benefit there is deploying this early.

There is any alternative to merge this and show them to the user when the translations come through ? maybe using some feature flag? just thinking out loud.

@lsl
Copy link
Contributor

lsl commented Apr 21, 2022

There is any alternative to merge this and show them to the user when the translations come through ? maybe using some feature flag? just thinking out loud.

There is a hasTranslate method in i18n-calypso but it's usage is quite clunky and nobody ever cleans them up so I don't really suggest it.

@lupus2k lupus2k merged commit a1942e4 into trunk Apr 28, 2022
@lupus2k lupus2k deleted the update/marketplace-cta-on-tools branch April 28, 2022 19:58
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Apr 28, 2022
@github-actions github-actions bot removed the [Status] String Freeze Add the [Status] String Freeze label to your PR to ensure new strings are translated before merging label Apr 28, 2022
@a8ci18n
Copy link

a8ci18n commented Apr 28, 2022

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants