Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the White Screen to view Website #62799

Closed

Conversation

Akash-Ramjyothi
Copy link

Changes proposed in this Pull Request

Fixes White Screen from wordpress.com/view link to view website by adding localize() to a component.

@sirbrillig
Copy link
Member

I'm not 100% sure what bug this solves since there's no testing instructions (I don't get a white screen at https://wordpress.com/view, so maybe it requires some specific steps to reproduce) but it seems worth mentioning that the translate function was removed by #61732 and put into another file (client/components/web-preview/connectedContent.jsx) instead. cc @escapemanuele / @alshakero in case that caused a regression somewhere.

@dsas
Copy link
Contributor

dsas commented Jan 6, 2023

I don't get a white screen either, even when using a non-default locale and I can't see any open issues reporting this.

As far as I understand the current code, it will always be wrapped by localize except when the isContentOnly prop is passed, which only happens in design picker and launchpad, neither of which white screen for me.

I'm going to close this PR @Akash-Ramjyothi, we are really grateful for the contribution though. If you can remember anything more about this, then please just drop a comment and let us know and we can look again :).

@dsas dsas closed this Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants