-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stats: Improvements to video stats #63173
Conversation
…Changed URL for video file attachment link to go to Calypso media library
…ging type of data in VideoPressStatsModule
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~1042 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~19 bytes added 📈 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review seems 👍
// Only show loading indicators when nothing is in state tree, and request in-flight | ||
const isLoading = ! this.state.loaded && ! ( data && data.length ); | ||
|
||
// TODO: Support error state in redux store |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Errant TODO
- not sure we planned to do this or it was copy-pastad?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably 🍝 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified that it was copied, removed in 5ef4172
Co-authored-by: John Caruso <johncaruso@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
…ormailizer to return additional required data.
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/7279210 Hi @thedebian, could you please edit the description of this PR and add a screenshot for our translators? Ideally it'd include this string: Thank you in advance! |
Translation for this Pull Request has now been finished. |
Changes proposed in this Pull Request
This PR updates video stats to add watch time and impressions.
It also changes "plays" to "views" and fixes some existing issues with Video stats.
Testing instructions
Related to Automattic/greenhouse#1170