New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stepper: Added FlowProgress component to stepper #63413
Conversation
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: App Entrypoints (~97 bytes added 📈 [gzipped])
Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
I was looking at this other PR that implements this feature and I find it strange that the data management is not done as part of this PR. Maybe we should add a We could have only one selector that receives a |
I just created a separate PR for the sake of having the smallest self-contained PR, and in this case the step progress can technically be used without the store part. And we could be easier to review. When you say a 'key', do you mean in the data management side, right? Like we pass the siteId for most |
e6e907f
to
f89ed45
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just verify why the tests are failing to be sure if it's safe to merge.
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/7307319 Thank you @nelsonec87 for including a screenshot in the description! This is really helpful for our translators. |
Changes proposed in this Pull Request
FlowProgress
, that shows information like "Step 2 of 10".Testing instructions
FlowProgress
in a step you should add a new prop toStepContainer
:In this example the values are hard-coded, but the idea is to store this information in the
ONBOARD_STORE
, so it's manageable from the flow configuration instead on the step (since the step may be used in different flows).The store changes are on a different PR.
Related to #63355