Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marketplace: check for preinstalled plugins by slug. #63613

Merged
merged 5 commits into from May 18, 2022

Conversation

cpapazoglou
Copy link
Contributor

@cpapazoglou cpapazoglou commented May 13, 2022

  • move array with slug constants to a more central file
  • reuse these constants in plugin details page
  • make sure to show these plugins as installed and active. We might also need to check for the current plan site features active.

Changes proposed in this Pull Request

  • check preinstalled plugins by slug

Testing instructions

  • search for 'jetpack','akismet','vaultpress','gutenberg','full-site-editing','layout-grid','page-optimize'
  • make sure that these plugins appear as installed and active in plugin browser list and plugin details page
Before After
CleanShot 2022-05-13 at 17 04 21@2x CleanShot 2022-05-13 at 17 05 09@2x
CleanShot 2022-05-18 at 16 20 23@2x CleanShot 2022-05-18 at 16 20 35@2x

Related to p1652448293562329-slack-C029JEQRVRT

@cpapazoglou cpapazoglou self-assigned this May 13, 2022
@matticbot
Copy link
Contributor

matticbot commented May 13, 2022

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~165 bytes added 📈 [gzipped])

name         parsed_size           gzip_size
plugins           +493 B  (+0.1%)     +105 B  (+0.1%)
marketplace       +161 B  (+0.0%)      +60 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@cpapazoglou cpapazoglou marked this pull request as ready for review May 18, 2022 13:21
@cpapazoglou cpapazoglou requested a review from Copons May 18, 2022 13:21
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label May 18, 2022
@matticbot
Copy link
Contributor

This PR modifies the release build for editing-toolkit

To test your changes on WordPress.com, run install-plugin.sh editing-toolkit fix/preinstalled_plugins on your sandbox.

To deploy your changes after merging, see the documentation: PCYsg-mMA-p2

@epeicher epeicher self-requested a review May 18, 2022 14:43
Copy link
Contributor

@epeicher epeicher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the listed plugins jetpack,akismet,vaultpress,gutenberg,full-site-editing,layout-grid,page-optimize and they all work as expected.

LGTM! 🚢

@cpapazoglou cpapazoglou merged commit c23e4fe into trunk May 18, 2022
@cpapazoglou cpapazoglou deleted the fix/preinstalled_plugins branch May 18, 2022 15:19
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label May 18, 2022
@a8ci18n
Copy link

a8ci18n commented May 18, 2022

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/7315115

Thank you @cpapazoglou for including a screenshot in the description! This is really helpful for our translators.

@a8ci18n
Copy link

a8ci18n commented May 25, 2022

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants