Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Help Center: Move directly to a package #63657

Merged
merged 17 commits into from May 26, 2022
Merged

Help Center: Move directly to a package #63657

merged 17 commits into from May 26, 2022

Conversation

alshakero
Copy link
Member

@alshakero alshakero commented May 16, 2022 •
edited

Summary

  1. This PR adds Directly to the support options. We have moved the directly code into the help-center package.
  2. Moves Spinner from calypso/components to packages/components.
  3. Uses the new package in the help center.

Testing

  1. Apply D81418-code to get Directly eligibility for every user.
  2. Pull the branch and run cd apps/editing-toolkit/ && yarn dev --sync
  3. Go check the HelpCenter contact form and it should automatically go to Directly.

Regression testing - important

  1. Using a free user (user without any purchases) visit http://calypso.localhost:3000/help/contact.
  2. Type something and send the question.
  3. Directly popup should appear.

Related to #63655

@github-actions
Copy link

github-actions bot commented May 16, 2022 •
edited by matticbot

Calypso Live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-34292
Jetpack Cloud live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-34292&env=jetpack

@alshakero alshakero mentioned this pull request May 16, 2022
Closed
5 tasks
@escapemanuele escapemanuele self-assigned this May 16, 2022
@escapemanuele escapemanuele added the [Feature] Help Center The new integrated Help Center in Calypso that provides support tools on all screens. label May 16, 2022
@escapemanuele escapemanuele added this to In progress in Vertex Team Board via automation May 16, 2022
@arcangelini arcangelini requested a review from a team May 18, 2022 23:48
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label May 18, 2022
@matticbot
Copy link
Contributor

This PR modifies the release build for editing-toolkit

To test your changes on WordPress.com, run install-plugin.sh editing-toolkit move/directoy-to-package on your sandbox.

To deploy your changes after merging, see the documentation: PCYsg-mMA-p2

@arcangelini arcangelini moved this from In progress to Needs review in Vertex Team Board May 19, 2022
@arcangelini arcangelini marked this pull request as ready for review May 19, 2022 09:38
@alshakero alshakero requested review from a team as code owners May 24, 2022 14:32
@alshakero alshakero changed the title Spike: move directly to a package Help Center: Move directly to a package May 24, 2022
@alshakero alshakero removed request for a team May 24, 2022 14:38
@AllTerrainDeveloper
Copy link
Contributor

Email related code (Letero owned code) seems good to me :)

@matticbot
Copy link
Contributor

matticbot commented May 24, 2022 •
edited

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~85 bytes added 📈 [gzipped])

name           parsed_size           gzip_size
entry-stepper       +109 B  (+0.0%)      +85 B  (+0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~825 bytes added 📈 [gzipped])

name                            parsed_size           gzip_size
purchases                            +305 B  (+0.0%)      +51 B  (+0.0%)
domains                              +291 B  (+0.0%)      +71 B  (+0.0%)
site-purchases                       +277 B  (+0.0%)      +40 B  (+0.0%)
checkout                             +277 B  (+0.0%)      +40 B  (+0.0%)
help                                 +264 B  (+0.0%)      +96 B  (+0.1%)
jetpack-connect                      +137 B  (+0.0%)      +28 B  (+0.0%)
security                             +123 B  (+0.0%)      +94 B  (+0.1%)
import                               +123 B  (+0.0%)       +9 B  (+0.0%)
notification-settings                +109 B  (+0.0%)      +16 B  (+0.0%)
email                                +109 B  (+0.0%)      +25 B  (+0.0%)
backup                               +109 B  (+0.0%)      +18 B  (+0.0%)
account-close                        +109 B  (+0.0%)      +41 B  (+0.0%)
account                              +109 B  (+0.0%)      +63 B  (+0.0%)
hosting                               +99 B  (+0.0%)      +19 B  (+0.0%)
themes                                +95 B  (+0.0%)      +14 B  (+0.0%)
theme                                 +95 B  (+0.0%)      +16 B  (+0.0%)
stats                                 +95 B  (+0.0%)      +18 B  (+0.0%)
site-blocks                           +95 B  (+0.0%)      +28 B  (+0.0%)
settings-writing                      +95 B  (+0.0%)      +10 B  (+0.0%)
scan                                  +95 B  (+0.0%)       +7 B  (+0.0%)
privacy                               +95 B  (+0.0%)      +31 B  (+0.0%)
plugins                               +95 B  (+0.0%)      +10 B  (+0.0%)
plans                                 +95 B  (+0.0%)      +12 B  (+0.0%)
people                                +95 B  (+0.0%)      +11 B  (+0.0%)
migrate                               +95 B  (+0.0%)      +16 B  (+0.0%)
me                                    +95 B  (+0.0%)      +31 B  (+0.0%)
home                                  +95 B  (+0.0%)      +13 B  (+0.0%)
happychat                             +95 B  (+0.0%)      +31 B  (+0.0%)
export                                +95 B  (+0.0%)      +12 B  (+0.0%)
customize                             +95 B  (+0.0%)      +17 B  (+0.0%)
concierge                             +95 B  (+0.0%)      +14 B  (+0.0%)
activity                              +95 B  (+0.0%)      +23 B  (+0.0%)
woocommerce-installation              +81 B  (+0.0%)      +11 B  (+0.0%)
woocommerce                           +81 B  (+0.0%)      +11 B  (+0.0%)
sites                                 +81 B  (+0.0%)      +11 B  (+0.0%)
settings-security                     +81 B  (+0.0%)      +11 B  (+0.0%)
settings-performance                  +81 B  (+0.0%)      +11 B  (+0.0%)
settings-jetpack                      +81 B  (+0.0%)      +11 B  (+0.0%)
settings-discussion                   +81 B  (+0.0%)      +11 B  (+0.0%)
settings                              +81 B  (+0.0%)      +11 B  (+0.0%)
reader                                +81 B  (+0.0%)      +40 B  (+0.0%)
purchase-product                      +81 B  (+0.1%)      +42 B  (+0.1%)
preview                               +81 B  (+0.0%)      +12 B  (+0.0%)
posts-custom                          +81 B  (+0.0%)      +11 B  (+0.0%)
posts                                 +81 B  (+0.0%)      +11 B  (+0.0%)
pages                                 +81 B  (+0.0%)      +11 B  (+0.0%)
media                                 +81 B  (+0.0%)      +62 B  (+0.0%)
marketplace                           +81 B  (+0.0%)      -12 B  (-0.0%)
marketing                             +81 B  (+0.0%)      +11 B  (+0.0%)
jetpack-social                        +81 B  (+0.0%)      +11 B  (+0.0%)
jetpack-search                        +81 B  (+0.0%)      +11 B  (+0.0%)
jetpack-cloud-settings                +81 B  (+0.0%)      +11 B  (+0.0%)
jetpack-cloud-pricing                 +81 B  (+0.0%)      +11 B  (+0.0%)
jetpack-cloud-partner-portal          +81 B  (+0.0%)      +57 B  (+0.0%)
jetpack-cloud-agency-dashboard        +81 B  (+0.0%)      +53 B  (+0.1%)
jetpack-cloud                         +81 B  (+0.0%)      +11 B  (+0.0%)
gutenberg-editor                      +81 B  (+0.0%)      +11 B  (+0.0%)
google-my-business                    +81 B  (+0.0%)      +11 B  (+0.0%)
earn                                  +81 B  (+0.0%)      +11 B  (+0.0%)
comments                              +81 B  (+0.0%)      +11 B  (+0.0%)
devdocs                               +67 B  (+0.0%)      +57 B  (+0.1%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~3168 bytes added 📈 [gzipped])

name                                                                          parsed_size           gzip_size
async-load-calypso-layout-masterbar-checkout-tsx                                  +6761 B  (+1.0%)    +2108 B  (+1.0%)
async-load-calypso-layout-masterbar-checkout                                      +6761 B  (+1.2%)    +2135 B  (+1.3%)
async-load-calypso-my-sites-checkout-modal                                        +5724 B  (+0.4%)    +1670 B  (+0.5%)
async-load-design-playground                                                       -967 B  (-0.1%)     -222 B  (-0.1%)
async-load-design                                                                  -314 B  (-0.0%)      +82 B  (+0.0%)
async-load-calypso-blocks-inline-help-popover                                      +236 B  (+0.0%)      +91 B  (+0.1%)
async-load-calypso-blocks-editor-checkout-modal                                    +196 B  (+0.0%)      +21 B  (+0.0%)
async-load-signup-steps-import-from                                                 +95 B  (+0.0%)      +13 B  (+0.0%)
async-load-signup-steps-site-picker                                                 +81 B  (+0.0%)       +5 B  (+0.0%)
async-load-signup-steps-difm-site-picker                                            +81 B  (+0.0%)       +9 B  (+0.0%)
async-load-calypso-components-web-preview-component                                 +81 B  (+0.0%)      +61 B  (+0.0%)
async-load-calypso-components-sites-popover                                         +81 B  (+0.1%)      +10 B  (+0.0%)
async-load-signup-steps-website-content                                             +67 B  (+0.1%)      +84 B  (+0.2%)
async-load-signup-steps-site-topic                                                  +67 B  (+0.1%)      +33 B  (+0.1%)
async-load-signup-steps-p2-join-workspace                                           +67 B  (+0.1%)      +29 B  (+0.1%)
async-load-signup-steps-p2-complete-profile                                         +67 B  (+0.0%)      +25 B  (+0.1%)
async-load-calypso-layout-popup-search                                              +67 B  (+0.5%)      +15 B  (+0.4%)
async-load-calypso-components-webpack-build-monitor                                 +67 B  (+2.0%)      +19 B  (+1.3%)
async-load-calypso-components-jetpack-portal-nav                                    +67 B  (+0.2%)      +18 B  (+0.1%)
async-load-calypso-blocks-login-two-factor-authentication-two-factor-content        +67 B  (+0.3%)      +19 B  (+0.3%)
async-load-store-app-store-stats-listview                                           +14 B  (+0.0%)       +3 B  (+0.0%)
async-load-store-app-store-stats                                                    +14 B  (+0.0%)       +7 B  (+0.0%)
async-load-design-blocks                                                            -14 B  (-0.0%)       -2 B  (-0.0%)
async-load-calypso-my-sites-sidebar                                                 +14 B  (+0.0%)       -1 B  (-0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@alshakero alshakero force-pushed the move/directoy-to-package branch 2 times, most recently from ba003ec to 00fef66 Compare May 25, 2022 14:43
escapemanuele
escapemanuele approved these changes May 25, 2022
View reviewed changes
Copy link
Contributor

@escapemanuele escapemanuele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's really impressive 🚀

@alshakero alshakero merged commit 6302aab into trunk May 26, 2022
Vertex Team Board automation moved this from Needs review to Done May 26, 2022
@alshakero alshakero deleted the move/directoy-to-package branch May 26, 2022 08:32
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label May 26, 2022
@a8ci18n
Copy link

a8ci18n commented May 26, 2022

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/7333249

Hi @alshakero, could you please edit the description of this PR and add a screenshot for our translators? Ideally it'd include all of the following strings:

  • Start live chat with an expert
  • These are others, like yourself, who have been selected because of their WordPress.com knowledge to help answer questions.
  • An expert user will be with you right away
  • Ask an expert
  • Connecting you to an expert

Thank you in advance!

@a8ci18n
Copy link

a8ci18n commented Jun 2, 2022

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@escapemanuele escapemanuele escapemanuele approved these changes

Assignees

@arcangelini arcangelini

Labels
[Feature] Help Center The new integrated Help Center in Calypso that provides support tools on all screens.
Projects
Vertex Team Board
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@alshakero @matticbot @AllTerrainDeveloper @a8ci18n @escapemanuele @arcangelini