-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add submission success page #63680
Add submission success page #63680
Conversation
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~499 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but please replace SVG's with gridicons before merging.
client/my-sites/marketplace/pages/submission-success/signup-success.tsx
Outdated
Show resolved
Hide resolved
client/my-sites/marketplace/pages/submission-success/signup-success.tsx
Outdated
Show resolved
Hide resolved
Could probably ship this as is though there are some console warnings, looks like something to do with the SVG styling. |
Thanks for reviewing @lsl and replacing the svg's with gridicons. I'll replace the SVG for a correspondent PNG image, so we don't need to style it (changing dash-case to camelCase attributes) and as we can see, the quality becomes better by just copying and pasting the image: |
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/7314271 Thank you @paulopmt1 for including a screenshot in the description! This is really helpful for our translators. |
Translation for this Pull Request has now been finished. |
Changes proposed in this Pull Request
http://calypso.localhost:3000/marketplace/submission-success
route.http://calypso.localhost:3000/marketplace/thank-you/woocommerce-subscriptions/politicaemvideira.com
screenTesting instructions
Related to #63554