Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add submission success page #63680

Merged
merged 9 commits into from
May 17, 2022
Merged

Add submission success page #63680

merged 9 commits into from
May 17, 2022

Conversation

paulopmt1
Copy link
Contributor

@paulopmt1 paulopmt1 commented May 16, 2022

Changes proposed in this Pull Request

  • Added a new submission success page on http://calypso.localhost:3000/marketplace/submission-success route.
  • Reused MasterbarStyled from the http://calypso.localhost:3000/marketplace/thank-you/woocommerce-subscriptions/politicaemvideira.com screen

Testing instructions

image

  • It should work in all supported browsers
  • It should work on mobile

Related to #63554

@paulopmt1 paulopmt1 added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label May 16, 2022
@paulopmt1 paulopmt1 requested a review from a team as a code owner May 16, 2022 17:49
@paulopmt1 paulopmt1 self-assigned this May 16, 2022
@github-actions
Copy link

github-actions bot commented May 16, 2022

@matticbot
Copy link
Contributor

matticbot commented May 16, 2022

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~499 bytes added 📈 [gzipped])

name         parsed_size           gzip_size
marketplace      +2251 B  (+0.3%)     +499 B  (+0.3%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@sirbrillig sirbrillig removed the request for review from a team May 16, 2022 18:58
@allilevine allilevine requested a review from a team May 16, 2022 20:43
Copy link
Contributor

@lsl lsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please replace SVG's with gridicons before merging.

@lsl
Copy link
Contributor

lsl commented May 17, 2022

Could probably ship this as is though there are some console warnings, looks like something to do with the SVG styling.

@paulopmt1
Copy link
Contributor Author

paulopmt1 commented May 17, 2022

Thanks for reviewing @lsl and replacing the svg's with gridicons. I'll replace the SVG for a correspondent PNG image, so we don't need to style it (changing dash-case to camelCase attributes) and as we can see, the quality becomes better by just copying and pasting the image:

image

@paulopmt1 paulopmt1 merged commit ac3f29d into trunk May 17, 2022
@paulopmt1 paulopmt1 deleted the add_signup_success_page branch May 17, 2022 13:35
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label May 17, 2022
@a8ci18n
Copy link

a8ci18n commented May 17, 2022

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/7314271

Thank you @paulopmt1 for including a screenshot in the description! This is really helpful for our translators.

@a8ci18n
Copy link

a8ci18n commented May 25, 2022

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants