Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marketplace: Remove extra whitespace after apostrophe #63755

Merged
merged 2 commits into from
May 18, 2022

Conversation

yuliyan
Copy link
Member

@yuliyan yuliyan commented May 18, 2022

Changes proposed in this Pull Request

  • Remove extra whitespace after apostrophe in a translatable string

Testing instructions

  • Code review

Related to p1652862898149819-slack-CEM18K8LT

@yuliyan yuliyan requested review from lsl, paulopmt1 and a team May 18, 2022 10:08
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label May 18, 2022
@github-actions
Copy link

github-actions bot commented May 18, 2022

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@jornp jornp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚢

@yuliyan yuliyan merged commit 6a9b93e into trunk May 18, 2022
@yuliyan yuliyan deleted the fix/marketplace-remove-extra-whitespace-in-string branch May 18, 2022 11:18
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label May 18, 2022
@a8ci18n
Copy link

a8ci18n commented May 18, 2022

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/7314881

Hi @yuliyan, could you please edit the description of this PR and add a screenshot for our translators? Ideally it'd include this string: We’ll be in touch

Thank you in advance!

@a8ci18n
Copy link

a8ci18n commented May 25, 2022

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants