-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plans overhaul: Add Google Analytics for Starter #63766
Conversation
Add GA to my-plan page Add GA to thank-you page
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: App Entrypoints (~93 bytes added 📈 [gzipped])
Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used. Sections (~199 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~174 bytes added 📈 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
@claudiucelfilip @southp I'm guessing we'll do the recording and the Starter subtitle update in this PR (added to the TODO list). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as described.
LGTM🚀
The remaining updates are now consolidated in 747-gh-Automattic/martech. Please incorporate them into this PR 🙇🏼 |
This PR modifies the release build for editing-toolkit To test your changes on WordPress.com, run To deploy your changes after merging, see the documentation: PCYsg-mMA-p2 |
@southp The changes are pushed to this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've confirmed that the new order and the new plan description are implemented as expected. LGTM 🚢
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/7320581 Thank you @chriskmnds for including a screenshot in the description! This is really helpful for our translators. |
Translation for this Pull Request has now been finished. |
Changes proposed in this Pull Request
plans/my-plan
(this will also be included in the about-to-be-obsolete "free vs pro" grid, but I guess that's fine - it will just be marked with "not included")
Media
start/plans
plans/my-plan
Testing instructions
/start/plans
and select "show full plan comparison"/plans/[SITE_ON_FREE_OR_STARTER]
and select "show full plan comparison"/plans/my-plan/[SITE_ON_STARTER]
and confirm a GA block is there/start/plans
and purchase a Starter plan. Complete the checkout/start/plans?flags=-plans/starter-plan
) and ensure nothing breaks.TODO
Related to Automattic/martech#741
Fixes Automattic/martech#741