Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show Stripe Account in Dashboard #63873

Merged
merged 3 commits into from
Jun 6, 2022
Merged

Conversation

pottedmeat
Copy link
Contributor

Changes proposed in this Pull Request

  • Add connected_account_description from memberships/status to the store
  • Show the currently connected account below the Disconnect action
  • Show the previously connected account above the Connect action

Testing instructions

  • Apply D80890-code to add the new API field
  • Visit the Collect payments area of the Earn tools
  • For a connected account, verify that it appears in the Disconnect row
  • For a disconnected account that had created a plan, verify that it appears above the Connect button

image

image

Related to #46551

@pottedmeat pottedmeat self-assigned this May 20, 2022
@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~139 bytes added 📈 [gzipped])

name       parsed_size           gzip_size
earn            +814 B  (+0.2%)     +128 B  (+0.1%)
purchases        +81 B  (+0.0%)      +11 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Member

@sirbrillig sirbrillig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@pottedmeat pottedmeat merged commit 1039305 into trunk Jun 6, 2022
@pottedmeat pottedmeat deleted the add/show-connected-stripe-account branch June 6, 2022 14:51
@a8ci18n
Copy link

a8ci18n commented Jun 6, 2022

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/7360657

Thank you @pottedmeat for including a screenshot in the description! This is really helpful for our translators.

@a8ci18n
Copy link

a8ci18n commented Jun 16, 2022

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants