-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement welcome banner for agency dashboard #63949
Conversation
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: App Entrypoints (~105 bytes added 📈 [gzipped])
Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used. Sections (~724 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~9 bytes removed 📉 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
443bd7f
to
4cc5f4c
Compare
client/jetpack-cloud/sections/agency-dashboard/sites-overview/site-welcome-banner/index.tsx
Outdated
Show resolved
Hide resolved
client/jetpack-cloud/sections/agency-dashboard/sites-overview/site-welcome-banner/index.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and works as expected. Just a couple of super minor suggestions.
@manzoorwanijk - Thanks for the review, I have made the changes according to your comments. |
45b42d6
to
df83f15
Compare
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/7328797 Thank you @yashwin for including a screenshot in the description! This is really helpful for our translators. |
Translation for this Pull Request has now been finished. |
Changes proposed in this Pull Request
This PR adds banners to highlight the agency dashboard on the dashboard page and licenses page.
Testing instructions
Prerequisites
Make sure you are not an agency partner, if yes set it back to internal - 2c49b-pb
Instructions
git checkout add/welcome-banner-to-agency-dashboard
andyarn start-jetpack-cloud
View
button on the banner on the licenses page, it should take you to the dashboard page(/dashboard
)Got it
button, the banner should be hidden now.Screenshots
Licenses Page
Dashboard Page
Related to 1202076982646589-as-1202228745081082