Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement welcome banner for agency dashboard #63949

Merged
merged 2 commits into from
May 24, 2022

Conversation

yashwin
Copy link
Contributor

@yashwin yashwin commented May 24, 2022

Changes proposed in this Pull Request

This PR adds banners to highlight the agency dashboard on the dashboard page and licenses page.

Testing instructions

Prerequisites

Make sure you are not an agency partner, if yes set it back to internal - 2c49b-pb

Instructions

  1. Run git checkout add/welcome-banner-to-agency-dashboard and yarn start-jetpack-cloud
  2. Apply D79008-code to your sandbox for the mock API to work.
  3. Visit http://jetpack.cloud.localhost:3000/partner-portal/licenses directly without visiting the dashboard page or http://jetpack.cloud.localhost:3000/ and verify that no banner is shown since you are not an agency user.
  4. Now, set yourself(partner) as an agency - 2c49b-pb
  5. Refresh the licenses page without visiting the dashboard page, and verify that the banner is shown now.
  6. Click on the View button on the banner on the licenses page, it should take you to the dashboard page(/dashboard)
  7. Verify that the banner is shown on the dashboard page as shown in the screenshot below
  8. Go back to the licenses page again, now the banner should be hidden(since you have visited the dashboard page)
  9. Got back to the dashboard page, you should still see the banner.
  10. Click on the Got it button, the banner should be hidden now.
  11. Refresh the page to make sure the banner is not appearing again.

Screenshots

Licenses Page

Screenshot 2022-05-24 at 1 15 02 PM

Dashboard Page

Screenshot 2022-05-24 at 1 14 44 PM

Related to 1202076982646589-as-1202228745081082

@matticbot
Copy link
Contributor

matticbot commented May 24, 2022

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~105 bytes added 📈 [gzipped])

name                   parsed_size           gzip_size
entry-main                  +506 B  (+0.0%)     +105 B  (+0.0%)
entry-stepper               +126 B  (+0.0%)      +42 B  (+0.0%)
entry-login                 +126 B  (+0.0%)      +42 B  (+0.0%)
entry-gutenboarding         +126 B  (+0.0%)      +42 B  (+0.0%)
entry-domains-landing       +126 B  (+0.0%)      +42 B  (+0.0%)
entry-browsehappy           +126 B  (+0.1%)      +42 B  (+0.1%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~724 bytes added 📈 [gzipped])

name                            parsed_size            gzip_size
jetpack-cloud-agency-dashboard     +72610 B  (+29.8%)   +19096 B  (+24.4%)
jetpack-cloud-partner-portal       +62692 B  (+17.4%)   +17639 B  (+16.4%)
account                              +183 B   (+0.0%)     +350 B   (+0.2%)
comments                              +51 B   (+0.0%)     -154 B   (-0.1%)
site-purchases                        -13 B   (-0.0%)       -9 B   (-0.0%)
purchases                             -13 B   (-0.0%)       -9 B   (-0.0%)
checkout                              -13 B   (-0.0%)       -9 B   (-0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~9 bytes removed 📉 [gzipped])

name                                             parsed_size           gzip_size
async-load-calypso-my-sites-checkout-modal             -13 B  (-0.0%)       -9 B  (-0.0%)
async-load-calypso-blocks-editor-checkout-modal        -13 B  (-0.0%)       -9 B  (-0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@yashwin yashwin self-assigned this May 24, 2022
@yashwin yashwin added Jetpack Jetpack Cloud Anything related to the Jetpack Cloud (cloud.jetpack.com) labels May 24, 2022
@yashwin yashwin force-pushed the add/welcome-banner-to-agency-dashboard branch from 443bd7f to 4cc5f4c Compare May 24, 2022 08:28
@yashwin yashwin requested a review from a team May 24, 2022 08:37
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label May 24, 2022
@yashwin yashwin marked this pull request as ready for review May 24, 2022 08:37
Copy link
Member

@manzoorwanijk manzoorwanijk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works as expected. Just a couple of super minor suggestions.

@yashwin
Copy link
Contributor Author

yashwin commented May 24, 2022

Looks good and works as expected. Just a couple of super minor suggestions.

@manzoorwanijk - Thanks for the review, I have made the changes according to your comments.

@yashwin yashwin force-pushed the add/welcome-banner-to-agency-dashboard branch from 45b42d6 to df83f15 Compare May 24, 2022 12:55
@yashwin yashwin merged commit 8ddc09b into trunk May 24, 2022
@yashwin yashwin deleted the add/welcome-banner-to-agency-dashboard branch May 24, 2022 13:07
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label May 24, 2022
@a8ci18n
Copy link

a8ci18n commented May 24, 2022

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/7328797

Thank you @yashwin for including a screenshot in the description! This is really helpful for our translators.

@a8ci18n
Copy link

a8ci18n commented Jun 2, 2022

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Jetpack Cloud Anything related to the Jetpack Cloud (cloud.jetpack.com) Jetpack
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants