Provide translated list of goals to be displayed by the "Goals Capture Step" screen #63961

mashikag · 2022-05-24T13:07:18Z

Creating a hook that will provide a list of translated 'goals' that are to be displayed in the "Capture Goals" step of the setup flow.

Changes proposed in this Pull Request

new goals step hook to provide a list of translated goals that are to be displayed in the new Capture Goals screen

Testing instructions

No real testing instructions for this. As long as it does not regress any current functionality, it should introduce no changes to the current UI.

The hook will be verified at the time of implementing the new Capture Goals screen which will consume the returned data.

Related to #63959

Creating a hook that will provide a list of translated 'goals' that are to be displayed in the "Capture Goals" step of the setup flow.

github-actions · 2022-05-24T13:07:35Z

Calypso Live (direct link)

	https://calypso.live?image=registry.a8c.com/calypso/app:build-34229

Jetpack Cloud live (direct link)

	https://calypso.live?image=registry.a8c.com/calypso/app:build-34229&env=jetpack

matticbot · 2022-05-24T13:16:12Z

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

client/signup/steps/goals/goals.tsx

client/signup/steps/goals/constants.ts

client/signup/steps/goals/types.ts

ivan-ottinger · 2022-05-24T15:15:04Z

Just one observation comment: I see we are putting the files inside client/signup/steps/goals/. In our other PR (#63866) we used client/signup/steps/goals-step/ (similarly to intent-step), but I prefer simpler goals directory as is used in this PR. 👍🏼

→ We will adjust the directory in #63866.

- Rename useIntents to useGoals hook - Re-order GoalKey values - Use `key` and `title` instead of `id` and `label` as keys of Goal type object

ivan-ottinger · 2022-05-25T08:36:08Z

While looking at the file locations again today, there's one thing that's not clear to me.

My understanding was that our new Goals step will live in client/landing/stepper/declarative-flow/internals/steps-repository/goals/. But in this PR we are putting the files inside client/signup/steps/goals instead. 🤔

mashikag · 2022-05-25T09:35:33Z

While looking at the file locations again today, there's one thing that's not clear to me.

My understanding was that our new Goals step will live in client/landing/stepper/declarative-flow/internals/steps-repository/goals/. But in this PR we are putting the files inside client/signup/steps/goals instead. 🤔

You are right @ivan-ottinger ! Let me fix the directory. 👍

yansern · 2022-05-25T09:55:51Z

Yup, /client/signup for /start, and /client/landing/stepper for all the stepper stuff.

And as to where things should be placed, not too worried at the moment, one could argue the hook could be inside /client/landing/stepper/hooks. I think this PR is good to go.

a8ci18n · 2022-05-25T14:17:01Z

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/7331366

Hi @mashikag, could you please edit the description of this PR and add a screenshot for our translators? Ideally it'd include all of the following strings:

Write and publish
Sell goods or products
Promote myself or my business
Hire a professional to design my website
Import my existing website content

Thank you in advance!

a8ci18n · 2022-06-02T14:29:55Z

Translation for this Pull Request has now been finished.

Provide translated list of goals to be displayed by UI

6e96ac2

Creating a hook that will provide a list of translated 'goals' that are to be displayed in the "Capture Goals" step of the setup flow.

mashikag requested a review from a team May 24, 2022 13:07

matticbot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels May 24, 2022

mashikag linked an issue May 24, 2022 that may be closed by this pull request

[Data] Implement a hook providing a list of goals for UI to display #63959

Closed