-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable add/remove mailbox buttons based on user permissions #64322
Disable add/remove mailbox buttons based on user permissions #64322
Conversation
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~102 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
&:hover { | ||
&.is-selected, | ||
&:hover, | ||
&:focus { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -420,10 +422,10 @@ | |||
width: 100%; | |||
|
|||
.email-plan-warnings__warning { | |||
padding-top: 30px; | |||
padding-top: 24px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -375,7 +382,7 @@ const EmailMailboxActionMenu = ( { account, domain, mailbox } ) => { | |||
visible={ removeTitanMailboxDialogVisible } | |||
/> | |||
) } | |||
<EllipsisMenu position="bottom" className="email-mailbox-action-menu__main"> | |||
<EllipsisMenu position="bottom left" className="email-mailbox-action-menu__main"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had minor suggestions but otherwise this looks good, and works great.
client/my-sites/email/email-management/home/email-plan-warnings.jsx
Outdated
Show resolved
Hide resolved
a608692
to
065b8e8
Compare
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/7366362 Thank you @fredrikekelund for including a screenshot in the description! This is really helpful for our translators. |
Translation for this Pull Request has now been finished. |
Proposed Changes
For sites with multiple users, only the owner of the Titan/Google Workspace subscription is allowed to add/remove mailboxes. Currently, there is no preemptive warning to users about this. This means that they can click the button to add/remove mailboxes, but the action will fail.
With this change, the "Remove mailbox" button is hidden entirely and the "Add new mailboxes" button is disabled if the current user isn't allowed to perform those actions. We also display an explanation in
EmailPlanHeader
for why the buttons are disabled.Testing Instructions
/email/:domain/manage/:site_slug
Only the email subscription owner can add or remove mailboxes.
Related to #