-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stepper - Seller Experience: Edit email step #64462
Conversation
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/7366846 Thank you @markbiek for including a screenshot in the description! This is really helpful for our translators. |
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: App Entrypoints (~513 bytes added 📈 [gzipped])
Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
4ecc9df
to
9e19bd5
Compare
I was testing the happy path, I got the verification email but the screen reads The email is directed to the correct email tough. |
@andres-blanco Good catch. I bet the I probably need to store the edited email somewhere and have |
9e19bd5
to
e21f7fe
Compare
This is used to store the value entered from the editEmail step
e21f7fe
to
ae3812c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested both paths and it's looking good!
Thanks @andres-blanco !
I think we're in good shape. Merging as soon as the tests pass. |
Click "Edit email" from `wooVerifyEmail` takes you to the `editEmail` step. Success after clicking "Send a verification to my new email" takes the user back to `wooVerifyEmail`.
67aa423
to
693dd17
Compare
Translation for this Pull Request has now been finished. |
Proposed Changes
This adds a new step allowing the user to edit their account email address.
Clicking "Edit email" from
wooVerifyEmail
takes you to theeditEmail
step.Success after clicking "Send a verification to my new email" takes the user back to
wooVerifyEmail
.Testing Instructions
** Success testing **
wooVerifyEmail
step and should receive a verification email.** Failure testing **
Closes #64163
CleanShot.2022-06-09.at.10.13.13.mp4
** Initial view **
** Error sending verification email **