Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stepper - Seller Experience: Edit email step #64462

Merged
merged 3 commits into from
Jun 10, 2022

Conversation

markbiek
Copy link
Contributor

@markbiek markbiek commented Jun 8, 2022

Proposed Changes

This adds a new step allowing the user to edit their account email address.

Clicking "Edit email" from wooVerifyEmail takes you to the editEmail step.

Success after clicking "Send a verification to my new email" takes the user back to wooVerifyEmail.

Testing Instructions

** Success testing **

  1. Go to http://calypso.localhost:3000/setup/wooVerifyEmail?siteSlug=[slug]&flags=signup/woo-verify-email and click "Edit email address".
  2. Enter a new, unique email address and click "Send a verification to my new email".
  3. You should be taken back to the wooVerifyEmail step and should receive a verification email.

** Failure testing **

  1. Go to http://calypso.localhost:3000/setup/wooVerifyEmail?siteSlug=[slug]&flags=signup/woo-verify-email and click "Edit email address".
  2. Enter an email address that's already in use (like bobo@bob.com) and click "Send a verification to my new email".
  3. You should see an error notice as pictured below.

Closes #64163

CleanShot.2022-06-09.at.10.13.13.mp4

** Initial view **
image

** Error sending verification email **
CleanShot 2022-06-09 at 10 14 00

@markbiek markbiek added [Status] String Freeze Add the [Status] String Freeze label to your PR to ensure new strings are translated before merging DO NOT MERGE labels Jun 8, 2022
@markbiek markbiek self-assigned this Jun 8, 2022
@a8ci18n
Copy link

a8ci18n commented Jun 8, 2022

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/7366846

Thank you @markbiek for including a screenshot in the description! This is really helpful for our translators.

@matticbot
Copy link
Contributor

matticbot commented Jun 8, 2022

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~513 bytes added 📈 [gzipped])

name                 parsed_size           gzip_size
entry-stepper            +2281 B  (+0.1%)     +456 B  (+0.0%)
entry-gutenboarding       +188 B  (+0.0%)      +57 B  (+0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@markbiek markbiek force-pushed the 64164-update/edit-email-step branch 3 times, most recently from 4ecc9df to 9e19bd5 Compare June 9, 2022 14:17
@markbiek markbiek requested a review from a team June 9, 2022 14:20
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jun 9, 2022
@markbiek markbiek added [Feature Group] Customer Seller Experience The customer experience when purchasing services or products. Stepper and removed DO NOT MERGE labels Jun 9, 2022
@markbiek markbiek changed the title WIP: 64164 update/edit email step Stepper - Seller Experience: Edit email step Jun 9, 2022
@andres-blanco
Copy link
Contributor

I was testing the happy path, I got the verification email but the screen reads A verification email has been sent to [OLD_EMAIL]. I expected the message to refer to the email I've just entered. (You can see this behaviour in the video you posted).

The email is directed to the correct email tough.

@markbiek
Copy link
Contributor Author

I was testing the happy path, I got the verification email but the screen reads A verification email has been sent to [OLD_EMAIL]. I expected the message to refer to the email I've just entered. (You can see this behaviour in the video you posted).

The email is directed to the correct email tough.

@andres-blanco Good catch. I bet the wooVerifyEmail step is pulling the current account email.

I probably need to store the edited email somewhere and have wooVerifyEmail conditionally load it.

@markbiek markbiek force-pushed the 64164-update/edit-email-step branch from 9e19bd5 to e21f7fe Compare June 10, 2022 14:28
@markbiek markbiek force-pushed the 64164-update/edit-email-step branch from e21f7fe to ae3812c Compare June 10, 2022 15:28
Copy link
Contributor

@andres-blanco andres-blanco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested both paths and it's looking good!

@markbiek
Copy link
Contributor Author

markbiek commented Jun 10, 2022

Thanks @andres-blanco !

I haven't been able to thoroughly test myself because of my working-copy problems but I'll get those WIP commits cleaned up once I've got that figured out.

I think we're in good shape. Merging as soon as the tests pass.

Click "Edit email" from `wooVerifyEmail` takes you to the `editEmail`
step.

Success after clicking "Send a verification to my new email" takes the
user back to `wooVerifyEmail`.
@markbiek markbiek force-pushed the 64164-update/edit-email-step branch from 67aa423 to 693dd17 Compare June 10, 2022 19:21
@markbiek markbiek merged commit 2056e65 into trunk Jun 10, 2022
@markbiek markbiek deleted the 64164-update/edit-email-step branch June 10, 2022 19:35
@github-actions github-actions bot removed [Status] String Freeze Add the [Status] String Freeze label to your PR to ensure new strings are translated before merging [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Jun 10, 2022
@a8ci18n
Copy link

a8ci18n commented Jun 16, 2022

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature Group] Customer Seller Experience The customer experience when purchasing services or products. Stepper
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Woo Email Confirmation - Trigger email resend on button click
4 participants