Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Google Sign-in: Migrate the pop-up flow to the new Google Identity Services API #64957

Merged
merged 8 commits into from Jun 30, 2022
Merged

Google Sign-in: Migrate the pop-up flow to the new Google Identity Services API #64957

merged 8 commits into from Jun 30, 2022

Commits on Jun 27, 2022

  1. Register the feature flag

    @zaguiini
    zaguiini committed Jun 27, 2022
    Copy the full SHA
    d22ec71 View commit details
    Browse the repository at this point in the history

  2. Init the new Google APIs behind a feature flag

    @zaguiini
    zaguiini committed Jun 27, 2022
    Copy the full SHA
    3c8bec1 View commit details
    Browse the repository at this point in the history

  3. Trigger authorization code request on click behind a feature flag

    @zaguiini
    zaguiini committed Jun 27, 2022
    Copy the full SHA
    585abb5 View commit details
    Browse the repository at this point in the history

  4. Exchange authorization code for tokens with the back-end and pass it … 

    …to the responseHandler
    @zaguiini
    zaguiini committed Jun 27, 2022
    Copy the full SHA
    788c4d9 View commit details
    Browse the repository at this point in the history

  5. Handle errors related to auth code exchange and display feedback on t… 

    …he UI
    @zaguiini
    zaguiini committed Jun 27, 2022
    Copy the full SHA
    f51ba8a View commit details
    Browse the repository at this point in the history

  6. Adapt responseHandler to the new format behind a feature flag

    @zaguiini
    zaguiini committed Jun 27, 2022
    Copy the full SHA
    8d3b779 View commit details
    Browse the repository at this point in the history

Commits on Jun 30, 2022

  1. Display error message as a toast instead of disabling the button

    @zaguiini
    zaguiini committed Jun 30, 2022
    Copy the full SHA
    393ffe0 View commit details
    Browse the repository at this point in the history

  2. Make error message more explicit

    @zaguiini
    zaguiini committed Jun 30, 2022
    Copy the full SHA
    9466acb View commit details
    Browse the repository at this point in the history