Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Signup: Update the copy of the processing screen #65076

Merged
merged 1 commit into from
Jun 29, 2022
Merged

Signup: Update the copy of the processing screen #65076

merged 1 commit into from
Jun 29, 2022

Conversation

arthur791004
Copy link
Contributor

Proposed Changes

  • Fix isDestinationSetupSiteFlow is incorrect as the URL has changed
  • Use "Turning on the lights" as the default message for the processing screen
signup-processing-screen.mov

Testing Instructions

  • Go to /start
  • Finish the signup flow and you will see "Turning on the lights" shown on the processing screen

Related to #65024

@arthur791004 arthur791004 requested a review from a team June 29, 2022 07:54
@arthur791004 arthur791004 self-assigned this Jun 29, 2022
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jun 29, 2022
@arthur791004 arthur791004 marked this pull request as ready for review June 29, 2022 07:55
@github-actions
Copy link

github-actions bot commented Jun 29, 2022 •
edited by matticbot
Loading

Calypso Live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-36583
Jetpack Cloud live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-36583&env=jetpack

@arthur791004 arthur791004 force-pushed the fix/get-rid-of-applying-design branch from 41c2559 to 536146e Compare June 29, 2022 07:59
@matticbot
Copy link
Contributor

matticbot commented Jun 29, 2022 •
edited
Loading

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~26 bytes added 📈 [gzipped])

name    parsed_size           gzip_size
signup        +86 B  (+0.0%)      +26 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

taipeicoder
taipeicoder approved these changes Jun 29, 2022
View reviewed changes
Copy link
Contributor

@taipeicoder taipeicoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢

@arthur791004 arthur791004 merged commit cbe208a into trunk Jun 29, 2022
@arthur791004 arthur791004 deleted the fix/get-rid-of-applying-design branch June 29, 2022 08:36
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jun 29, 2022
ddc22 pushed a commit that referenced this pull request Jun 30, 2022
@arthur791004 @ddc22
Signup: Update the copy of the processing screen (#65076)
49229e6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taipeicoder taipeicoder taipeicoder approved these changes

Assignees

@arthur791004 arthur791004

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@arthur791004 @matticbot @taipeicoder