Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signup: Add more messages on the processing screen #65106

Merged
merged 1 commit into from
Jul 11, 2022

Conversation

arthur791004
Copy link
Contributor

@arthur791004 arthur791004 commented Jun 30, 2022

Proposed Changes

  • Add more messages on the processing screen
signup-processing-screen.mov

Testing Instructions

  • Go to /start
  • Finish the singup flow
  • You will see following messages on the processing screen
    • Turning on the lights
    • Making you cookies
    • Planning the next chess move

Related to #65024 (comment)

@arthur791004 arthur791004 self-assigned this Jun 30, 2022
@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~29 bytes added 📈 [gzipped])

name    parsed_size           gzip_size
signup        +74 B  (+0.0%)      +29 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@arthur791004 arthur791004 added the [Status] String Freeze Add the [Status] String Freeze label to your PR to ensure new strings are translated before merging label Jun 30, 2022
@a8ci18n
Copy link

a8ci18n commented Jun 30, 2022

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/7407350

Hi @arthur791004, could you please edit the description of this PR and add a screenshot for our translators? Ideally it'd include all of the following strings:

  • Building your site
  • Laying the foundations
  • Turning on the lights
  • Making it beautiful
  • Sprinkling some magic
  • Preparing your domain
  • Making you cookies
  • Planning the next chess move

Thank you in advance!

@arthur791004 arthur791004 requested a review from a team June 30, 2022 03:37
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jun 30, 2022
Copy link
Contributor

@taipeicoder taipeicoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's wait for the translation before merging 🙂

@a8ci18n
Copy link

a8ci18n commented Jul 8, 2022

Translation for this Pull Request has now been finished.

@taipeicoder taipeicoder merged commit add3378 into trunk Jul 11, 2022
@taipeicoder taipeicoder deleted the feat/add-more-msgs-to-processing-screen branch July 11, 2022 01:45
@github-actions github-actions bot removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Status] String Freeze Add the [Status] String Freeze label to your PR to ensure new strings are translated before merging labels Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants