Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import: skip WordPress Migration selector for WP imports starting from I don't have a website #65146

Merged
merged 4 commits into from Jul 4, 2022

Conversation

ouikhuan
Copy link
Contributor

@ouikhuan ouikhuan commented Jul 1, 2022

Proposed Changes

  • When a user starts the import flow from "I don't have a site address" and click WordPress later to import their content, the migration selector screen is shown for two options "Import everything" and "import content only", which "import everything" option doesn't make sense in this particular flow.
  • Redirect user to import content only block if a user doesn't have a site address.
  • Remove the "Import Everything" part from "View the import guide" modal if a user doesn't have a site address.

Testing Instructions

  1. Navigate to /setup/import?siteSlug={SLUG}.
  2. Click "I don't have a site address" on the right top corner.
  3. Click WordPress option.
  4. Click "View the import guide" to see if there's only "Import Content Only" description.
  5. Click "Import your content" -> you should be pointed to "Import content from WordPress page" directly.
  6. Click "< Back" on the left top corner.
  7. Type in a site address and hit enter.
  8. Click "What can be imported" to see if there are both "Import Content Only" and "Import Everything".
  9. Click "Import your content" -> you will be brought to the original migration selector page.

Before:

mirgation-selector-before.mov

After:

mirgration-selector-after.mov

Screenshot for the wording changed:

Screen Shot 2022-07-04 at 3 50 13 PM

Related to #64364

@ouikhuan ouikhuan requested a review from bogiii July 1, 2022 02:23
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jul 1, 2022
@matticbot
Copy link
Contributor

matticbot commented Jul 1, 2022

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~152 bytes added 📈 [gzipped])

name           parsed_size           gzip_size
entry-stepper       +263 B  (+0.0%)     +152 B  (+0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@bogiii bogiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 🚢

@ouikhuan ouikhuan merged commit 8ca55b8 into trunk Jul 4, 2022
@ouikhuan ouikhuan deleted the update/skip-wp-migration-selector branch July 4, 2022 03:16
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jul 4, 2022
@a8ci18n
Copy link

a8ci18n commented Jul 4, 2022

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/7416486

Thank you @ouikhuan for including a screenshot in the description! This is really helpful for our translators.

@a8ci18n
Copy link

a8ci18n commented Jul 7, 2022

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants