Licensing Portal: Improve no primary payment method error clarity

[atanas-dev]

Proposed Changes

• Licensing Portal: Improve no primary payment method error clarity

Testing Instructions

• Switch your account to an agency and your testing key billing type to "Stripe".
• Make sure you don't have a payment method.
• Click on the "Assign" on any unassigned license and confirm the wording makes sense.
• Apply this diff so this edge case is easy to trigger:

diff --git a/client/jetpack-cloud/sections/partner-portal/issue-license-form/index.tsx b/client/jetpack-cloud/sections/partner-portal/issue-license-form/index.tsx
index 33c608f46c..b4c1abfc34 100644
--- a/client/jetpack-cloud/sections/partner-portal/issue-license-form/index.tsx
+++ b/client/jetpack-cloud/sections/partner-portal/issue-license-form/index.tsx
@@ -128,7 +128,7 @@ export default function IssueLicenseForm( {
 
 			switch ( error.code ) {
 				case 'missing_valid_payment_method':
-					if ( paymentMethodRequired ) {
+					if ( false && paymentMethodRequired ) {
 						page.redirect(
 							addQueryArgs(
 								{

• Open up http://jetpack.cloud.localhost:3000/partner-portal/issue-license?product=jetpack-complete and confirm the same error shows up.
  

[github-actions]

Calypso Live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-37064

Jetpack Cloud live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-37064&env=jetpack

[matticbot]

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

[heydemoura]

LGTM

[a8ci18n]

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/7423264

Thank you @atanas-dev for including a screenshot in the description! This is really helpful for our translators.

[a8ci18n]

Translation for this Pull Request has now been finished.