Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Plan Overhaul revert " #65779

Merged
merged 1 commit into from Jul 20, 2022

Conversation

claudiucelfilip
Copy link
Contributor

Reverts #64370

@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jul 20, 2022
@claudiucelfilip claudiucelfilip self-assigned this Jul 20, 2022
Copy link
Contributor

@gmovr gmovr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks LGTM

@matticbot
Copy link
Contributor

This PR modifies the release build for editing-toolkit

To test your changes on WordPress.com, run install-plugin.sh editing-toolkit revert-64370-update/plan-overhaul-revert on your sandbox.

To deploy your changes after merging, see the documentation: PCYsg-mMA-p2

@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~262 bytes removed 📉 [gzipped])

name                   parsed_size           gzip_size
entry-main                  -941 B  (-0.1%)     -117 B  (-0.0%)
entry-stepper               -623 B  (-0.0%)     -203 B  (-0.0%)
entry-login                 -207 B  (-0.0%)      -58 B  (-0.0%)
entry-gutenboarding         -207 B  (-0.0%)      -58 B  (-0.0%)
entry-browsehappy           -207 B  (-0.2%)      -58 B  (-0.2%)
entry-domains-landing       -196 B  (-0.0%)      -52 B  (-0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~2749 bytes removed 📉 [gzipped])

name                            parsed_size           gzip_size
media                              +38116 B  (+1.9%)   +10524 B  (+2.1%)
migrate                              -718 B  (-0.2%)     -298 B  (-0.3%)
settings-performance                 +711 B  (+0.1%)      -19 B  (-0.0%)
backup                               +697 B  (+0.1%)      +34 B  (+0.0%)
scan                                 +687 B  (+0.1%)      +54 B  (+0.0%)
hosting                              +635 B  (+0.1%)      -66 B  (-0.0%)
themes                               +603 B  (+0.1%)      -80 B  (-0.0%)
home                                 -603 B  (-0.1%)     -225 B  (-0.1%)
signup                               -534 B  (-0.1%)      -23 B  (-0.0%)
accept-invite                        -534 B  (-0.1%)      -23 B  (-0.0%)
earn                                 -477 B  (-0.1%)     -226 B  (-0.1%)
plugins                              +472 B  (+0.1%)      -99 B  (-0.0%)
jetpack-connect                      -465 B  (-0.0%)      +56 B  (+0.0%)
domains                              +305 B  (+0.0%)     -198 B  (-0.0%)
google-my-business                   -196 B  (-0.0%)     -871 B  (-0.6%)
jetpack-social                       +172 B  (+0.0%)     +574 B  (+0.5%)
activity                             +169 B  (+0.0%)      -24 B  (-0.0%)
settings-security                    +163 B  (+0.0%)      +69 B  (+0.1%)
settings-writing                     +157 B  (+0.0%)     +289 B  (+0.2%)
marketplace                          +152 B  (+0.0%)      -65 B  (-0.0%)
settings                             +147 B  (+0.0%)     +121 B  (+0.1%)
settings-jetpack                     +144 B  (+0.0%)     +619 B  (+0.6%)
gutenberg-editor                     -130 B  (-0.0%)      -53 B  (-0.0%)
marketing                            +110 B  (+0.0%)      -53 B  (-0.0%)
stats                                 -84 B  (-0.0%)      +15 B  (+0.0%)
plans                                 -69 B  (-0.0%)      -29 B  (-0.0%)
theme                                 -64 B  (-0.0%)      +22 B  (+0.0%)
checkout                              -56 B  (-0.0%)      -64 B  (-0.0%)
site-purchases                        +55 B  (+0.0%)      +14 B  (+0.0%)
settings-discussion                   +55 B  (+0.0%)     +806 B  (+0.8%)
purchases                             +55 B  (+0.0%)      +14 B  (+0.0%)
purchase-product                      +55 B  (+0.0%)      +14 B  (+0.0%)
jetpack-cloud-pricing                 +55 B  (+0.0%)      +83 B  (+0.1%)
jetpack-cloud-agency-dashboard        -54 B  (-0.0%)      -24 B  (-0.0%)
posts-custom                          -47 B  (-0.0%)      -82 B  (-0.0%)
posts                                 -47 B  (-0.0%)      -82 B  (-0.0%)
reader                                -40 B  (-0.0%)      -19 B  (-0.0%)
preview                               -40 B  (-0.0%)      -22 B  (-0.0%)
pages                                 -40 B  (-0.0%)     -207 B  (-0.1%)
people                                -38 B  (-0.0%)      +21 B  (+0.0%)
devdocs                               +36 B  (+0.0%)       +1 B  (+0.0%)
jetpack-search                        +31 B  (+0.0%)     -336 B  (-0.3%)
import                                -24 B  (-0.0%)     -365 B  (-0.3%)
export                                -24 B  (-0.0%)     -349 B  (-0.4%)
comments                              -24 B  (-0.0%)       -1 B  (-0.0%)
jetpack-cloud-settings                -14 B  (-0.0%)     -193 B  (-0.1%)
jetpack-cloud-partner-portal          -14 B  (-0.0%)       +2 B  (+0.0%)
help                                  -14 B  (-0.0%)       +2 B  (+0.0%)
email                                 -14 B  (-0.0%)       +2 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~16145 bytes removed 📉 [gzipped])

name                                                              parsed_size           gzip_size
async-load-calypso-post-editor-media-modal                           +38143 B  (+2.3%)   +10484 B  (+2.6%)
async-load-calypso-post-editor-editor-media-modal                    +38010 B  (+2.2%)    +9660 B  (+2.2%)
async-load-design-blocks                                             +34646 B  (+1.5%)    +9674 B  (+1.6%)
async-load-signup-steps-domains                                       +1401 B  (+0.3%)     +114 B  (+0.1%)
async-load-signup-steps-plans                                         -1161 B  (-0.4%)     -454 B  (-0.5%)
async-load-calypso-components-web-preview-component                    +374 B  (+0.1%)     +739 B  (+0.4%)
async-load-calypso-my-sites-checkout-modal                             -290 B  (-0.0%)     -131 B  (-0.0%)
async-load-calypso-reader-sidebar                                      +256 B  (+0.2%)     +881 B  (+2.4%)
async-load-calypso-my-sites-current-site-notice                        +256 B  (+0.3%)     +839 B  (+3.3%)
async-load-calypso-blocks-jitm-templates-sidebar-banner                +256 B  (+0.3%)     +566 B  (+2.6%)
async-load-calypso-blocks-jitm-templates-notice                        +256 B  (+0.3%)     +539 B  (+2.5%)
async-load-calypso-blocks-jitm-templates-default                       +256 B  (+0.3%)     +553 B  (+2.6%)
async-load-calypso-blocks-editor-checkout-modal                        -235 B  (-0.0%)     -111 B  (-0.0%)
async-load-calypso-blocks-jitm                                         -120 B  (-1.2%)      -21 B  (-0.6%)
async-load-signup-steps-design-picker                                  -105 B  (-0.1%)      -59 B  (-0.1%)
async-load-calypso-layout-masterbar-checkout-tsx                        -83 B  (-0.0%)      -16 B  (-0.0%)
async-load-calypso-layout-masterbar-checkout                            -83 B  (-0.0%)      -16 B  (-0.0%)
async-load-calypso-blocks-inline-help-popover                           -83 B  (-0.0%)      -16 B  (-0.0%)
async-load-calypso-my-sites-site-settings-seo-settings-form             +74 B  (+0.0%)       +9 B  (+0.0%)
async-load-signup-steps-plans-atomic-store                              +63 B  (+0.0%)       +8 B  (+0.0%)
async-load-calypso-my-sites-sidebar                                     -40 B  (-0.0%)      -26 B  (-0.1%)
async-load-calypso-components-jetpack-sidebar                           -40 B  (-0.0%)      -26 B  (-0.1%)
async-load-signup-steps-theme-selection                                 -16 B  (-0.0%)       -7 B  (-0.0%)
async-load-calypso-blocks-product-purchase-features-list                -15 B  (-0.0%)       -3 B  (-0.0%)
async-load-masterbar-cart-masterbar-cart-wrapper                        -14 B  (-0.0%)       +2 B  (+0.0%)
async-load-calypso-my-sites-current-site-stale-cart-items-notice        -14 B  (-0.0%)       +2 B  (+0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@gius80 gius80 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@claudiucelfilip claudiucelfilip merged commit 64f126c into trunk Jul 20, 2022
@claudiucelfilip claudiucelfilip deleted the revert-64370-update/plan-overhaul-revert branch July 20, 2022 13:36
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jul 20, 2022
@a8ci18n
Copy link

a8ci18n commented Jul 20, 2022

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/7450992

Hi @claudiucelfilip, could you please edit the description of this PR and add a screenshot for our translators? Ideally it'd include this string: With your plan, all WordPress.com advertising has been removed from your site. You can upgrade to a Business plan to also remove the WordPress.com footer credit.

Thank you in advance!

@a8ci18n
Copy link

a8ci18n commented Jul 20, 2022

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants