Update: Add subscriber form #65878

bogiii · 2022-07-22T09:54:42Z

Proposed Changes

Added @automattic/subscriber package with adding subscriber functionality (only static HTML for now)
Updated users page, people section replacing Email Followers with Subscribers introducing a new Add Subscriber form
Added a new route /people/add-subscribers/{SLUG}
Removed Follower and Subscribers roles from the Add/edit user form
Blurred out the subscriber form for the user without verified email

Testing Instructions

Add Subscriber form

Blurred out screen

Roles list

Added 'Add Subscriber' button

Pre-merge Checklist

Have you written new tests for your changes?
Have you tested the feature in Simple, Atomic, and self-hosted Jetpack sites?
Have you checked for TypeScript, React or other console errors?
Are we memoizing when appropriate (for expensive computations)? More info in Our Approach to Data and Memoizing with create-selector and Using memoizing selectors
Have we sent any new strings for translation ASAP?

Related to #

github-actions · 2022-07-22T09:55:03Z

Calypso Live (direct link)

	https://calypso.live?image=registry.a8c.com/calypso/app:build-40726

Jetpack Cloud live (direct link)

	https://calypso.live?image=registry.a8c.com/calypso/app:build-40726&env=jetpack

matticbot · 2022-07-22T09:55:53Z

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~69 bytes added 📈 [gzipped])

name           parsed_size           gzip_size
entry-main          -428 B  (-0.0%)      +30 B  (+0.0%)
entry-stepper       +331 B  (+0.0%)      +63 B  (+0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~12532 bytes added 📈 [gzipped])

name              parsed_size            gzip_size
people               +53297 B  (+10.2%)   +12858 B  (+8.4%)
posts-custom           -196 B   (-0.0%)     -645 B  (-0.4%)
posts                  -196 B   (-0.0%)     -645 B  (-0.4%)
checkout               +103 B   (+0.0%)      -16 B  (-0.0%)
settings-writing        -93 B   (-0.0%)     -590 B  (-0.3%)
settings                -28 B   (-0.0%)     -761 B  (-0.4%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

client/my-sites/people/followers-list/followers.jsx

client/my-sites/people/invite-button.jsx

mtias · 2022-08-02T10:01:40Z

client/my-sites/people/invite-people/index.jsx

-		} else if ( isAtomic ) {
-			defaultRole = 'subscriber';
-		}
+		const defaultRole = 'editor';


Not sure I follow the changes here, "subscriber" is also an internal WP role unrelated to the concept of email subscribers.

There is a request to remove 'Follower' and 'Subscriber' roles from the list of roles while you are adding new users. Here is the ticket: #65776

Because of that, we need to provide a default role, which is in this case 'editor'.

The screen is:

client/my-sites/people/people-add-subscribers/index.jsx

client/my-sites/people/people-section-nav/index.jsx

The route renders Add subscribers form screen

Closes #65666

Closes #65673

Closes #65675

Closes #65543

… emoji

Closes #65542

Closes #65635

…user Closes #65776

if the current user role is follower or subscriber. Relates #65776

Closes #65835

Relates #66255

Relates #66298

bogiii · 2022-09-05T09:03:12Z

Done through multiple pull requests, so I'm closing this PR:

bogiii added the Subscriber Importer label Jul 22, 2022

bogiii self-assigned this Jul 22, 2022

mtias reviewed Aug 2, 2022

View reviewed changes

client/my-sites/people/followers-list/followers.jsx Outdated Show resolved Hide resolved

mtias reviewed Aug 2, 2022

View reviewed changes

client/my-sites/people/invite-button.jsx Outdated Show resolved Hide resolved

mtias reviewed Aug 2, 2022

View reviewed changes

client/my-sites/people/people-add-subscribers/index.jsx Outdated Show resolved Hide resolved

mtias reviewed Aug 2, 2022

View reviewed changes

client/my-sites/people/people-section-nav/index.jsx Outdated Show resolved Hide resolved

bogiii added 20 commits August 4, 2022 12:01

Scaffold automattic/subscriber package

6ab3151

Update add subscriber form

a465fbf

Add subscribers form: add file upload and buttons controls

903098f

Set email list on change

b45bacb

Add email validation

f434a5a

Add upload file functionality

b87fe8b

Add upload file functionality

85bcde7

Add subscriber form: add optional props for showing skip btn

d5a070c

Registered 'people/add-subscribers' route

a43754d

The route renders Add subscribers form screen

Rename 'Email Followers' tab to 'Subscribers'

65499a9

Closes #65666

Rename 'Invites' tab to 'User Invites'

8af124c

Closes #65673

Rename 'Invite' button to 'Add User'

972ab0a

Closes #65675

Show missing Add User button on User Invites tab

07f19bd

Update UI allowing removing selected file

0b112af

Closes #65543

Subscriber form: extend property list allowing to hide/show title and…

14dd0bc

… emoji

Add subscriber form: cover notification case (info, warning, etc.)

af60c74

Closes #65542

Blur out the Add Subscriber form if the user email isn't verified

46b1cc5

Closes #65635

People UI: Remove follower and subscriber roles from the invite/edit …

69139e1

…user Closes #65776

Show follower/subscriber in role list for edit mode

cf527fb

if the current user role is follower or subscriber. Relates #65776

Update text replacing word follower with subscriber

0b441f2

Closes #65835

bogiii force-pushed the add/subscriber-package branch from 1c99874 to 0b441f2 Compare August 4, 2022 10:02

bogiii added 18 commits August 4, 2022 13:54

Update UI of select, replace, and remove a file

c83cf56

Relates #66255

Add subscriber form: add disclamer

9f985fb

Relates #66255

Add subsriber form: Update title

f0e0567

Relates #66255

Configure submit button name

9d4e9a1

Relates #66255

Add selected file extension validation

e6d4d63

Relates #66255

Create subscriber data store

abc0833

Relates #66298

Remove storybook lib from dev dependency

8ce8b32

Extend Subscribers form props list with siteId

af223b8

Relates #66298

Add hooks for active job recognision and inProgress state

ecccfb6

Add progress screen component

79757d9

Update subscriber data store

d54818b

Move store registration and config file to the root of module

3fb91d3

Adjust styles

ade642c

Show progress screen when import is in progress

9ed44e4

Remove unnecessary notice element

ca4c11c

Provide onImportFinish callback method

e6ca634

Properly install @automattic/subscriber package

f744d50

Make text changes

c138be2

This was referenced Aug 24, 2022

Add @automattic/subscriber package #66935

Merged

Add subscriber package integration with the Users section #67160

Merged

bogiii closed this Sep 5, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update: Add subscriber form #65878

Update: Add subscriber form #65878

bogiii commented Jul 22, 2022 •

edited

github-actions bot commented Jul 22, 2022 •

edited by matticbot

matticbot commented Jul 22, 2022 •

edited

mtias Aug 2, 2022

bogiii Aug 24, 2022

bogiii commented Sep 5, 2022 •

edited

Update: Add subscriber form #65878

Update: Add subscriber form #65878

Conversation

bogiii commented Jul 22, 2022 • edited

Proposed Changes

Testing Instructions

Pre-merge Checklist

github-actions bot commented Jul 22, 2022 • edited by matticbot

matticbot commented Jul 22, 2022 • edited

mtias Aug 2, 2022

Choose a reason for hiding this comment

bogiii Aug 24, 2022

Choose a reason for hiding this comment

bogiii commented Sep 5, 2022 • edited

bogiii commented Jul 22, 2022 •

edited

github-actions bot commented Jul 22, 2022 •

edited by matticbot

matticbot commented Jul 22, 2022 •

edited

bogiii commented Sep 5, 2022 •

edited