Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Social Auth: Remove Google API migration feature flag and obsolete code #66276

Merged
merged 4 commits into from Aug 5, 2022

Conversation

zaguiini
Copy link
Contributor

@zaguiini zaguiini commented Aug 4, 2022

Proposed Changes

Fixes #64791. Fixes #64538.

After a few weeks of having the migration/sign-in-with-google flag enabled in production, we did not notice any substantial reduction in conversions. This is backed by data: 2d132-pb.

Testing Instructions

The same as #64957, except for the need to activate the migration/sign-in-with-google flag (which is now the default).

Pre-merge Checklist

@zaguiini zaguiini requested a review from a team August 4, 2022 19:16
@zaguiini zaguiini self-assigned this Aug 4, 2022
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Aug 4, 2022
@matticbot
Copy link
Contributor

matticbot commented Aug 4, 2022

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~583 bytes removed 📉 [gzipped])

name         parsed_size           gzip_size
entry-login      -1928 B  (-0.2%)     -583 B  (-0.2%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~1153 bytes removed 📉 [gzipped])

name             parsed_size           gzip_size
jetpack-connect      -2039 B  (-0.2%)     -633 B  (-0.2%)
security             -1929 B  (-0.4%)     -520 B  (-0.4%)
accept-invite        -1916 B  (-0.4%)     -574 B  (-0.6%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~643 bytes removed 📉 [gzipped])

name                          parsed_size           gzip_size
async-load-design-blocks          -1928 B  (-0.1%)     -593 B  (-0.1%)
async-load-signup-steps-user      -1916 B  (-1.0%)     -574 B  (-1.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@danielbachhuber danielbachhuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Works well in my testing!

I was able to:

  • Successfully log in with my Google account.
  • Successfully sign up with my Google account.
  • Successfully connect and disconnect my Google account.

@zaguiini zaguiini merged commit 2fa987c into trunk Aug 5, 2022
@zaguiini zaguiini deleted the update/remove-google-auth-migration-feature-flag branch August 5, 2022 17:10
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants