-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add default payment block plan name #66338
Conversation
When adding a new payment plan for the Jetpack Payment Button block to use, the plan name will update depending upon the payment options selected - whether it's a donation and what the payment frequency is. This aids users in naming their plans appropriately. Making the form faster to fill in accurately. If the user explicitly chooses a name that differs from one of the possible defaults, then that is respected and not overwritten.
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~93 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/7467252 Thank you @dsas for including a screenshot in the description! This is really helpful for our translators. |
Translation for this Pull Request has now been finished. |
Proposed Changes
When adding a new payment plan for the Jetpack Payment Button block to
use, the plan name will update depending upon the payment options
selected - whether it's a donation and what the payment frequency is.
This aids users in naming their plans appropriately. Making the form
faster to fill in accurately.
If the user explicitly chooses a name that differs from one of the
possible defaults, then that is respected and not overwritten.
Testing Instructions
trim_jJSyOR.mp4
The below image shows the contents of the textbox with the title:
![image](https://user-images.githubusercontent.com/93301/183455817-cb7dad3b-bd35-4683-bbcf-76c392607502.png)
Pre-merge Checklist
Related to Automattic/jetpack#24074, it's essentially the Calypso version of Automattic/jetpack#25397