Sites Management Page: Visually distinguish 'redirect' sites

[danielbachhuber]

Fixes #66746

Proposed Changes

Visually distinguishes 'redirect' sites in the List view and Grid view, and uses site.options.unmapped_url instead of site.URL for redirect sites:

Testing Instructions

1. Create a new Free site.
2. Add the Site Redirect Add-On to the new Free site: https://wordpress.com/domains/add/site-redirect/
3. Navigate to /sites-dashboard.
4. Verify the Free site with redirect appears as expected in both List view and Grid view.

[github-actions]

Calypso Live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-40266

Jetpack Cloud live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-40266&env=jetpack

[matticbot]

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~101 bytes added 📈 [gzipped])

name             parsed_size           gzip_size
sites-dashboard       +618 B  (+0.3%)     +101 B  (+0.2%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

[zaguiini]

Works well 👍

One thing I noticed is that the site switcher displays both the site status pill and the redirect pill:

While the SMD only displays the redirect status:

But I don't think it's incorrect. The site status doesn't matter if it's a redirect because the redirect takes effect immediately, so it has precedence over the status. Is that correct?

If not (meaning we want to have parity), one thing we could do is to add a pill to the right of the site URL and maintain the status in its column.

[danielbachhuber]

The site status doesn't matter if it's a redirect because the redirect takes effect immediately, so it has precedence over the status. Is that correct?

Correct. Good thing we're refactoring the Site Switcher soon!

[zaguiini]

Great work 👍

[sejas]

Code looks good.
Tested and working as described.

I've found that the redirect shows a wrong empty state:

However, we can fix this in another PR.

wp-calypso/client/sites-dashboard/components/no-sites-message.tsx

Lines 104 to 105 in 839c330

	if ( status === 'coming-soon' ) {
	return (

[danielbachhuber]

I've found that the redirect shows a wrong empty state:

@sejas Great catch! Updated with 5d81f98

[zaguiini]

Great that we have the "no redirect sites" state now 👍

[a8ci18n]

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/7483033

Thank you @danielbachhuber for including a screenshot in the description! This is really helpful for our translators.

[p-jackson]

Thanks for the quick fix!

I took a look at the ellipsis menu actions for redirects, and although they work, they're perhaps not that relevant for a site redirect. Something for i2 I think.

Status isn't necessarily the greatest grouping to put Redirect under. I think of Status as short for Launch status, and Redirect isn't anything to do with that. But on the other hand Status is a made-up concept just for this dashboard, so we can sort of use it for whatever we want.

I thought about maybe hiding the Redirect from the dropdown unless the user actually has a redirect site. But maybe it's good advertising.

CC @SaxonF just making sure he's aware of the changes.

[SaxonF]

This is a good first pass, nice work @danielbachhuber !

[danielbachhuber]

Thanks for the quick fix!

@p-jackson You're welcome!

Status isn't necessarily the greatest grouping to put Redirect under. I think of Status as short for Launch status, and Redirect isn't anything to do with that. But on the other hand Status is a made-up concept just for this dashboard, so we can sort of use it for whatever we want.

Yeah, it's not a perfect abstraction. However, if Status represents the "state" of a site, then I think Redirect exists at the same level as Public, Private, and Coming Soon. Or, put another way, a Redirect will always redirect a user's site, so it doesn't matter if it's public or private.

I thought about maybe hiding the Redirect from the dropdown unless the user actually has a redirect site. But maybe it's good advertising.

I'd lean towards hiding from the dropdown unless there's at least one, too. Our Sites Management Page will become rapidly complex unless we actively keep the UI clear.

[p-jackson]

Or, put another way, a Redirect will always redirect a user's site, so it doesn't matter if it's public or private.

That's true. Putting Redirect in the column is better than something like N/A!

[a8ci18n]

Translation for this Pull Request has now been finished.