-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add feature flags and product lightbox placeholder #66751
Add feature flags and product lightbox placeholder #66751
Conversation
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~661 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The feature-flag is good. The dialog is functional and we can continue to build out the lightboxes off of this.
LGTM! 👍
@@ -233,6 +237,9 @@ const JetpackProductCard: React.FC< OwnProps > = ( { | |||
{ item.disclaimer && ( | |||
<span className="jetpack-product-card__disclaimer">{ item.disclaimer }</span> | |||
) } | |||
{ isEnabled( 'jetpack/pricing-page-product-lightbox' ) && ( | |||
<HintButton onClick={ onLearnMoreClick } /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was imagining the lightbox trigger as a "More about " text link inserted directly after the product description text, although I see in the PR description you describe this as a "temporary" button. So I guess we will remove the HintButton in a following PR, and replace it with a text link appended to the product description, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So yes, I decided to go this way firstly to have a quick solution to be able to test a feature flag quickly and found it easier to do with a small button and absolute
positioning not getting into messing with CSS.
I think we could stick with it until or if business decides to go with it as it will require more time (we actually haven't estimated it) to integrate it in current cards, rather then creating a new ones.
For example on this card there is almost no place for additional text and there is already is one Learn more
button. So it would be quite a challenging task which will actually will be visible to users in a very short period of time (until we finish new page)
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/7528472 Hi @andrii-lysenko, could you please edit the description of this PR and add a screenshot for our translators? Ideally it'd include this string: Thank you in advance! |
Translation for this Pull Request has now been finished. |
Proposed Changes
jetpack/pricing-page-product-lightbox
for adding Learn More button to Jetpack Products and Opening new product lightbox when clicking it.product-lightbox
.Testing Instructions
Feature Flag is disabled by default for every environment to avoid confusion. In order to enable it add
?flags=jetpack/pricing-page-product-lightbox
to the URL. Also important to note that elements likehint-button
and current version ofproduct-lightbox
are not per designs, but more like placeholders for future development and for testing Feature Flag.yarn start-jetpack-cloud
OR visit Jetpack Cloud Libe link below.http://jetpack.cloud.localhost:3000/pricing?flags=-jetpack/pricing-page-rework-v1,jetpack/pricing-page-product-lightbox
with appropriate Feature Flags.jetpack/pricing-page-product-lightbox
there is not hint buttonPre-merge Checklist
Related to #
Feature Flag: 1202796695664022-as-1202796695664073/f
Lightbox placeholder: 1202796695664022-as-1202796695664078/f