Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sites Management Page: Add title="" attributes to the buttons #66886

Merged
merged 1 commit into from Aug 24, 2022

Conversation

danielbachhuber
Copy link
Contributor

Proposed Changes

Adds title="" attributes to the buttons:

image

image

Testing Instructions

  1. Navigate to /sites-dashboard.
  2. Hover over the buttons to see the titles display.

@danielbachhuber danielbachhuber requested a review from a team August 23, 2022 18:51
@danielbachhuber danielbachhuber self-assigned this Aug 23, 2022
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Aug 23, 2022
@danielbachhuber danielbachhuber added the Reviewer Can Merge PR author indicates the reviewer is free to merge/deploy if they want to own the change. label Aug 23, 2022
@zaguiini
Copy link
Contributor

I think we can get rid of the aria-label attributes since the title is now read by the screen readers, right? @p-jackson might have more insights on a11y.

@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~13 bytes added 📈 [gzipped])

name             parsed_size           gzip_size
sites-dashboard        +62 B  (+0.0%)      +13 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@danielbachhuber
Copy link
Contributor Author

I think we can get rid of the aria-label attributes since the title is now read by the screen readers, right?

@zaguiini It seems like both might be preferable https://stackoverflow.com/questions/27953425/what-is-the-difference-between-aria-label-and-title-attributes

@zaguiini
Copy link
Contributor

Approved after testing with VoiceOver. The screen reader deals with both properties 👍

@p-jackson p-jackson merged commit cdff2e7 into trunk Aug 24, 2022
@p-jackson p-jackson deleted the add/sites-management-page-display-mode-titles branch August 24, 2022 03:33
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Aug 24, 2022
@a8ci18n
Copy link

a8ci18n commented Aug 24, 2022

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/7493170

Thank you @danielbachhuber for including a screenshot in the description! This is really helpful for our translators.

@a8ci18n
Copy link

a8ci18n commented Sep 2, 2022

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Reviewer Can Merge PR author indicates the reviewer is free to merge/deploy if they want to own the change. Sites Management Page i1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants