New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sites Management Page: Add title=""
attributes to the buttons
#66886
Sites Management Page: Add title=""
attributes to the buttons
#66886
Conversation
I think we can get rid of the |
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~13 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
@zaguiini It seems like both might be preferable https://stackoverflow.com/questions/27953425/what-is-the-difference-between-aria-label-and-title-attributes |
Approved after testing with VoiceOver. The screen reader deals with both properties 👍 |
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/7493170 Thank you @danielbachhuber for including a screenshot in the description! This is really helpful for our translators. |
Translation for this Pull Request has now been finished. |
Proposed Changes
Adds
title=""
attributes to the buttons:Testing Instructions
/sites-dashboard
.