Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin Details: Add plan periodicity to the plan USP #67174

Merged
merged 1 commit into from Aug 31, 2022

Conversation

WBerredo
Copy link
Collaborator

Proposed Changes

Add plan periodicity to the plan USP
Screen Shot 2022-08-30 at 15 12 29

Testing Instructions

  • Select a free site
  • Go to a paid plugin page. Ex:
  • Check if the periodicity is being shown on the plan USP
  • Change the billing selector option
  • Check if the periodicity change is reflected on the plan USP
  • Go to a free plugin page. Ex: /plugins/elementor/{site}
  • Check if the periodicity is being shown on the plan USP

Pre-merge Checklist

Fixes #67113

@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~59 bytes added 📈 [gzipped])

name                             parsed_size           gzip_size
plugins                               +121 B  (+0.0%)      +59 B  (+0.0%)
jetpack-cloud-plugin-management       +121 B  (+0.0%)      +59 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@gavande1 gavande1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected. LGTM 👍

@WBerredo WBerredo merged commit 8e85434 into trunk Aug 31, 2022
@WBerredo WBerredo deleted the update/plan-usps-periodicity branch August 31, 2022 14:44
@a8ci18n
Copy link

a8ci18n commented Aug 31, 2022

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/7505997

Thank you @WBerredo for including a screenshot in the description! This is really helpful for our translators.

@a8ci18n
Copy link

a8ci18n commented Sep 8, 2022

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plugin Details: add billing period right after the plan price in the sidebar
4 participants