Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plan: Update CTAs visual style on the plan management page #67423

Merged
merged 5 commits into from
Sep 28, 2022

Conversation

taggon
Copy link
Contributor

@taggon taggon commented Sep 6, 2022

Proposed Changes

  • This PR changes the CTAs visual style on the plan management page. ref: pebzTe-cs-p2

Testing Instructions

  • Go to a site on a paid plan.
  • Choose Upgrades > Plans on the left sidebar and click Manage plan on the main panel.
  • The CTAs below the plan details card should look as follows:
    screenshot-2022-09-05-at-15 33 30

Pre-merge Checklist

Related to #

@taggon taggon requested a review from a team as a code owner September 6, 2022 11:26
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Sep 6, 2022
@github-actions
Copy link

github-actions bot commented Sep 6, 2022

@taggon taggon added the [Status] String Freeze Add the [Status] String Freeze label to your PR to ensure new strings are translated before merging label Sep 6, 2022
@matticbot
Copy link
Contributor

matticbot commented Sep 6, 2022

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~142 bytes added 📈 [gzipped])

name            parsed_size           gzip_size
site-purchases       +611 B  (+0.0%)     +142 B  (+0.0%)
purchases            +611 B  (+0.0%)     +142 B  (+0.0%)
domains               +21 B  (+0.0%)       +5 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@DavidRothstein
Copy link
Contributor

I tried purchasing a subscription and going to the purchase management page and saw this:

cancel-subscription-and-refund

It looks odd to not have an icon here when all the other ones do, and the sentence case is inconsistent (i.e. it should presumably be "Cancel subscription and refund" to match the others). If you're going to add icons and switch to sentence case, I think you need to do it everywhere -- there are actually lots of examples like this (the above is just one), for example "Cancel Domain" when cancelling a domain has the same problem, and there are many more.

I also noticed that for a subscription outside the refund window, I see this (again, another example with problems like the above):

cancel-subscription-auto-renew-on

But more important, if I go through and click "Cancel Subscription" in the above to (disable auto-renew), I now wind up on this screen, with yet another "Cancel Subscription" link:

cancel-subscription-auto-renew-off

But this time the "Cancel Subscription" link has a completely different meaning (it actually removes the subscription). I think that would be extremely confusing to the user.

@JanaMW27
Copy link

JanaMW27 commented Sep 7, 2022

All cases with a cancelation button should follow the above design. The bin icon + the Cancel label, all in red.

@michaeldcain
Copy link
Member

@JanaMW27: what are your thoughts on @DavidRothstein's comment above?

if I go through and click "Cancel Subscription" in the above to (disable auto-renew), I now wind up on this screen, with yet another "Cancel Subscription" link:

But this time the "Cancel Subscription" link has a completely different meaning (it actually removes the subscription). I think that would be extremely confusing to the user.

I'm in agreement that having the same wording for two separate actions is very confusing (to the point that there will likely be users that click it again because they think the app didn't work correctly).

@JanaMW27
Copy link

I am currently working on changing the labels for this and improving the overall UX flow.
For now, let's have:
Cancel plan and refund (for user within refund window) In red and with the bin icon
Cancel plan (for a user outside the refund window) In red and with the bin icon
Remove plan (for a user with auto-renew off) In red and with the bin icon
I think this will work in the meantime.

@taggon taggon force-pushed the update/plan-management-page-cta branch from c23343a to 7890630 Compare September 15, 2022 12:11
@taggon
Copy link
Contributor Author

taggon commented Sep 15, 2022

Rebased.

@taggon
Copy link
Contributor Author

taggon commented Sep 15, 2022

Purchase_Settings_‹_Business_Monthly_—_WordPress_com

@JanaMW27 For expired purchases, the page shows Pick another plan instead of Upgrade plan but the upload icon doesn't fit the description. Could you give me another icon name for Pick another plan?

@JanaMW27
Copy link

Can we use this one?
view_carousel_24px_outlined

@taggon
Copy link
Contributor Author

taggon commented Sep 15, 2022

Purchase_Settings_—_WordPress_com

@JanaMW27 done. :)

@taggon
Copy link
Contributor Author

taggon commented Sep 15, 2022

All labels and icons are updated as per @JanaMW27 's suggestions.

@a8ci18n
Copy link

a8ci18n commented Sep 15, 2022

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/7528985

Thank you @taggon for including a screenshot in the description! This is really helpful for our translators.

@JanaMW27
Copy link

Thank you! Could I ask for a piece of feedback that came in yesterday? The cancel and remove labels, and the icon can they be the same color as the other buttons, rather than red?

@taggon
Copy link
Contributor Author

taggon commented Sep 15, 2022

The cancel and remove labels, and the icon can they be the same color as the other buttons, rather than red?

Purchase_Settings_‹_Premium_Monthly_—_WordPress_com

@JanaMW27 already done.

@JanaMW27
Copy link

Perfect! thank you!

@michaeldcain
Copy link
Member

@taggon: this feels really close. I tested the flows @DavidRothstein pointed out above, and they seem to be addressed. I did notice that after cancelling a domain, the button now says "Remove subscription". It should probably say "Remove domain" to follow the previous buttons.

Screen Shot 2022-09-16 at 2 08 26 PM

I also tested add-ons and one-time purchases (like single premium themes and quick start sessions). They both look good.

It looks to me like the only remaining product that needs updating (aside from the domains remove button) are Earn purchases, which use a different card. There's a FG page that covers testing these purchases (PCYsg-lW4-p2).

Screen Shot 2022-09-16 at 2 21 01 PM

@taggon
Copy link
Contributor Author

taggon commented Sep 19, 2022

the button now says "Remove subscription". It should probably say "Remove domain" to follow the previous buttons.

@michaeldcain Thanks for pointing it out. :) With the latest commit, the button says "Remove domain" if the purchase is a domain registration. The remove button of the Earn purchases should be handled in a follow-up PR to keep this PR focused on the plan management page. I'll create a new PR for that soon.
Purchase_Settings_—_WordPress_com

Copy link
Member

@michaeldcain michaeldcain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Thanks for following up on the Earn issue in a separate PR.

@taggon taggon force-pushed the update/plan-management-page-cta branch from 432e59d to 8f9088b Compare September 28, 2022 12:04
@taggon
Copy link
Contributor Author

taggon commented Sep 28, 2022

Rebased

@taggon taggon self-assigned this Sep 28, 2022
@taggon taggon merged commit a339a3f into trunk Sep 28, 2022
@taggon taggon deleted the update/plan-management-page-cta branch September 28, 2022 12:18
@github-actions github-actions bot removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Status] String Freeze Add the [Status] String Freeze label to your PR to ensure new strings are translated before merging labels Sep 28, 2022
@a8ci18n
Copy link

a8ci18n commented Sep 28, 2022

Translation for this Pull Request has now been finished.

@DavidRothstein
Copy link
Contributor

Created a followup issue for some small inconsistencies here, including the Earn issue mentioned above (which I don't think has a pull request yet): #68921

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants