Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pricing page rework: Extract items list component logic for re-usability #67485

Merged

Conversation

manzoorwanijk
Copy link
Member

@manzoorwanijk manzoorwanijk commented Sep 7, 2022

Proposed Changes

Testing Instructions

  • Do any one of these
  • Confirm that everything is same as before

Pre-merge Checklist

Screenshot 2022-09-07 at 5 16 32 PM

@manzoorwanijk manzoorwanijk added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Type] Task labels Sep 7, 2022
@manzoorwanijk manzoorwanijk requested a review from a team September 7, 2022 09:41
@manzoorwanijk manzoorwanijk self-assigned this Sep 7, 2022
@matticbot
Copy link
Contributor

matticbot commented Sep 7, 2022

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~1 bytes added 📈 [gzipped])

name                   parsed_size           gzip_size
plans                       -249 B  (-0.0%)       +1 B  (+0.0%)
jetpack-connect             -249 B  (-0.0%)       +1 B  (+0.0%)
jetpack-cloud-pricing       -249 B  (-0.0%)       +1 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@jkguidaven jkguidaven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM.. tested and it was working like before.

@manzoorwanijk manzoorwanijk enabled auto-merge (squash) September 7, 2022 10:13
@manzoorwanijk manzoorwanijk merged commit fa93b9c into trunk Sep 7, 2022
@manzoorwanijk manzoorwanijk deleted the update/jp-pricing-rework/extract-items-list-code branch September 7, 2022 10:20
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Sep 7, 2022
@a8ci18n
Copy link

a8ci18n commented Sep 7, 2022

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/7514766

Thank you @manzoorwanijk for including a screenshot in the description! This is really helpful for our translators.

@a8ci18n
Copy link

a8ci18n commented Sep 16, 2022

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants