New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pricing page rework: Extract items list component logic for re-usability #67485
Pricing page rework: Extract items list component logic for re-usability #67485
Conversation
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~1 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code LGTM.. tested and it was working like before.
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/7514766 Thank you @manzoorwanijk for including a screenshot in the description! This is really helpful for our translators. |
Translation for this Pull Request has now been finished. |
Proposed Changes
Testing Instructions
/pricing?flags=jetpack/pricing-page-rework-v1
git fetch && git checkout update/jp-pricing-rework/extract-items-list-code
yarn start-jetpack-cloud
Pre-merge Checklist