Launchpad: Add task helper and checklist unit tests #67524
Conversation
jeyip
added
[Status] Needs Review
| } ); | ||
| } ); | ||
|
|
||
| describe( 'when a non-existing flow is provided', () => { |
There was a problem hiding this comment.
It's strange that getArrayOfFilteredTasks returns null when no flow is provided and undefined when no tasks are found. Maybe we should rethink the return values?
There was a problem hiding this comment.
Do you think it should be an empty array in those cases? or other thoughts?
There was a problem hiding this comment.
I like empty arrays 👍. No need to type check for a false-y value anymore.
jeyip
changed the title
|
Testing
Working now using the correct command. |
There was a problem hiding this comment.
Im experiencing the same issues as Anthony with the yarn test launchpad/test/checklist.tsx command. Was it supposed to be yarn test-client launchpad/test/checklist.tsx instead? that seems to work for me.
Assuming that is the correct command, both test files are passing on my end.
My mistake y'all! @agrullon95 + @Addison-Stavlo It is supposed to be |
github-actions
bot
removed
the
[Status] Needs Review
|
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/7526401 Hi @jeyip, could you please edit the description of this PR and add a screenshot for our translators? Ideally it'd include this string: Thank you in advance! |
|
Translation for this Pull Request has now been finished. |
* Add task helper unit test * Add checklist unit test * Add checklist item unit test (#67530)
Proposed Changes
Testing Instructions
yarn test-client task-helperyarn test-client launchpad/test/checklist.tsxPre-merge Checklist
Related to #