Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marketplace: Add empty page for plans #67710

Merged
merged 9 commits into from
Sep 13, 2022
Merged

Conversation

candy02058912
Copy link
Contributor

@candy02058912 candy02058912 commented Sep 13, 2022

Proposed Changes

  • Adds a new /plugins/plans/:site route with empty content.

Testing Instructions

Related to #67574

@github-actions
Copy link

github-actions bot commented Sep 13, 2022

client/my-sites/plugins/plans/index.jsx Outdated Show resolved Hide resolved
client/my-sites/plugins/plans/index.jsx Outdated Show resolved Hide resolved
@matticbot
Copy link
Contributor

matticbot commented Sep 13, 2022

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~115 bytes added 📈 [gzipped])

name     parsed_size           gzip_size
plugins       +704 B  (+0.1%)     +115 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@lsl lsl marked this pull request as ready for review September 13, 2022 04:59
@candy02058912 candy02058912 merged commit 5ee25a2 into trunk Sep 13, 2022
@candy02058912 candy02058912 deleted the add/plugins-plan-empty branch September 13, 2022 06:20
@a8ci18n
Copy link

a8ci18n commented Sep 13, 2022

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/7525248

Thank you @candy02058912 for including a screenshot in the description! This is really helpful for our translators.

@a8ci18n
Copy link

a8ci18n commented Sep 21, 2022

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants