Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tailored Flow (1 min review): Link in bio intro text to set up #67718

Merged
merged 5 commits into from
Sep 13, 2022
Merged

Tailored Flow (1 min review): Link in bio intro text to set up #67718

merged 5 commits into from
Sep 13, 2022

Conversation

escapemanuele
Copy link
Contributor

@escapemanuele escapemanuele commented Sep 13, 2022 •
edited
Loading

Proposed Changes

Context: p1663060395372769-slack-C02T4NVL4JJ

Change LinkInBio Intro button text from Setup your Link in Bio to Set up your Link in Bio.

image

Testing Instructions

  • Check Calypso Live link
  • Button text should be Set up your Link in Bio
  • In other locales, there should still be the old translation

@github-actions
Copy link

github-actions bot commented Sep 13, 2022 •
edited by matticbot
Loading

Calypso Live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-42887
Jetpack Cloud live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-42887&env=jetpack

@escapemanuele escapemanuele changed the title Tailored Flow: Link in bio intro text to set up Tailored Flow (1 min review): Link in bio intro text to set up Sep 13, 2022
@escapemanuele escapemanuele requested a review from a team September 13, 2022 09:27
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Sep 13, 2022
@escapemanuele escapemanuele added this to In progress in Vertex Team Board via automation Sep 13, 2022
@escapemanuele escapemanuele self-assigned this Sep 13, 2022
@escapemanuele escapemanuele added [Feature] Tailored Onboarding Flows All onbaording flows targeted to a specific marketshare / audience. and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Sep 13, 2022
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Sep 13, 2022
@escapemanuele escapemanuele added Stepper and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Sep 13, 2022
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Sep 13, 2022
@escapemanuele escapemanuele moved this from In progress to Needs review in Vertex Team Board Sep 13, 2022
@simison
Copy link
Member

simison commented Sep 13, 2022

Thinking if this will bust translations? There's a function to keep using old string until everything is translated.

@simison
Copy link
Member

simison commented Sep 13, 2022

This one: https://github.com/Automattic/wp-calypso/tree/786367864f24125f0add3197dd14aabb959c4c26/packages/i18n-calypso#hastranslation-method

renancarvalho
renancarvalho approved these changes Sep 13, 2022
View reviewed changes
Copy link
Contributor

@renancarvalho renancarvalho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏅 ship it 🚢

@matticbot
Copy link
Contributor

matticbot commented Sep 13, 2022 •
edited
Loading

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~68 bytes added 📈 [gzipped])

name           parsed_size           gzip_size
entry-stepper       +322 B  (+0.0%)      +68 B  (+0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@escapemanuele
Copy link
Contributor Author

Thanks @simison, translations should be taken care of now!

@escapemanuele escapemanuele mentioned this pull request Sep 13, 2022
Open
4 tasks
simison
simison approved these changes Sep 13, 2022
View reviewed changes
Copy link
Member

@simison simison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful!

image

nuriapenya
nuriapenya approved these changes Sep 13, 2022
View reviewed changes
Copy link

@nuriapenya nuriapenya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@escapemanuele escapemanuele merged commit 78ea413 into trunk Sep 13, 2022
Vertex Team Board automation moved this from Needs review to Done Sep 13, 2022
@escapemanuele escapemanuele deleted the update/link-in-bio-intro-text-fix branch September 13, 2022 10:55
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Sep 13, 2022
@a8ci18n
Copy link

a8ci18n commented Sep 13, 2022

Translation for this Pull Request has now been finished.

@escapemanuele escapemanuele mentioned this pull request Sep 13, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simison simison simison approved these changes

@renancarvalho renancarvalho renancarvalho approved these changes

@nuriapenya nuriapenya nuriapenya approved these changes

Assignees

@escapemanuele escapemanuele

Labels
[Feature] Tailored Onboarding Flows All onbaording flows targeted to a specific marketshare / audience. Stepper
Projects
Vertex Team Board
Status: Done
Vertex Team Board
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@escapemanuele @simison @matticbot @a8ci18n @renancarvalho @nuriapenya