Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update availability message #67785

Merged
merged 1 commit into from
Sep 16, 2022
Merged

Conversation

gius80
Copy link
Contributor

@gius80 gius80 commented Sep 14, 2022

Proposed Changes

This PR updates the message that users with a suspended site receive when they try to create a new site.

This message is shown when the domain suggestion endpoint return a “blocked” error (which means that the user has a suspended site for violating the User Guidelines).

According to internal documentation the message should be:

Oops! Sorry an error has occurred. Please click here to contact us so that we can fix it. Please remember that you have to provide the full, complete Blog URL, otherwise we can not fix it.

domain before

domain after

Testing Instructions

Mark one of your sites as suspended, then try to create a new one: in the domain selection step, you should see the updated message.

@gius80 gius80 added the [Feature Group] Emails & Domains Features related to email integrations and domain management. label Sep 14, 2022
@github-actions
Copy link

github-actions bot commented Sep 14, 2022

@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~56 bytes added 📈 [gzipped])

name     parsed_size           gzip_size
domains        +88 B  (+0.0%)      +56 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~56 bytes added 📈 [gzipped])

name                             parsed_size           gzip_size
async-load-signup-steps-domains        +88 B  (+0.0%)      +56 B  (+0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@gius80 gius80 marked this pull request as ready for review September 14, 2022 11:46
@gius80 gius80 requested a review from a team as a code owner September 14, 2022 11:46
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Sep 14, 2022
Copy link
Contributor

@leonardost leonardost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Tested and works as expected. I just thought the "Please provide the blog URL" message part seemed a little weird, because I think the site slug will be put there in the error submission form 🤔 but I guess it's ok as it is.

@gius80 gius80 merged commit b3ff5b6 into trunk Sep 16, 2022
@gius80 gius80 deleted the update/blocked-availability-messages branch September 16, 2022 07:28
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Sep 16, 2022
@a8ci18n
Copy link

a8ci18n commented Sep 16, 2022

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/7530396

Thank you @gius80 for including a screenshot in the description! This is really helpful for our translators.

@a8ci18n
Copy link

a8ci18n commented Sep 21, 2022

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature Group] Emails & Domains Features related to email integrations and domain management.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants