New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sso options to wpcc signup flow #68080
Conversation
The logic was added in bba4f23 However, it doesn't not automatically log the user anymore so remove the logic
So that we can show the same UI after redirecting back to the calypso
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: App Entrypoints (~43 bytes added 📈 [gzipped])
Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used. Sections (~305 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~256 bytes added 📈 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
Confirmed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚢
* Perform regular login after SSO signup in the wpcc flow The logic was added in bba4f23 However, it doesn't not automatically log the user anymore so remove the logic * Update oauth-client form style for woo * Enable social signup for wpcc flow * Update redirect uri and save redirectToAfterLoginUrl for wpcc flow with Apple login * Persist url query string in apple sso state So that we can show the same UI after redirecting back to the calypso * Make sure the tos link display with woo color * Make social button width the same size * Catch sessionStorage.setItem error * Use winodw.location.origin directly for getRedirectUri instead * Redirect apple login to state.originalUrlPath * Fix social response handling * Make originalUrlPath configurable * Make queryString configurable * Update woo social signup enable logic and comment * Fix incorrect apple callback redirect query string
Proposed Changes
63-gh-woocommerce/team-ghidorah
This PR adds Apple and Google SSO options to wpcc signup flow for woocommerce.com.
Changes (please also check commits):
isSocialSignupEnabled
true for wpcc flow to show social signup formTesting Instructions
See "Testing Instructions" in #64957 to set up a working
wpcalypso.wordpress.com
environment on your local machine.Test Google Signup
Get Started
wpcalypso.wordpress.com
Screen.Recording.2022-09-08.at.15.17.46.mov
Test Apple Signup
Get Started
wpcalypso.wordpress.com
Screen.Recording.2022-09-08.at.15.19.53.mov
Pre-merge Checklist