-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the auto-renew toggle to use a link on Purchase Details #68105
Conversation
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~103 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
I've confirmed that it works as the test plan described. The code also looks good to me, but there is one accessibility issue: I can't focus on the new anchor-like button by tabbing, and the cursor doesn't change into a clickable pointer when hovering the mouse cursor onto it: I suppose the both might be the same issue, so the above screencast only demonstrates the cursor part :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fix works. LGTM 🚢
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/7542517 Thank you @dzver for including a screenshot in the description! This is really helpful for our translators. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this one clearly needs more discussion: pebzTe-j5-p2#comment-471
This component is used in several places. All other places should remain intact. The change will replace the Toggle component with an On/Off button in the middle of the Auto-renew ON copy.
Use a link button in order to make that work
@DavidRothstein raised a concern about the flow not being immediately clear with this heading. Rename it to make it more clear what it is
29f05ba
to
d38c805
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This approval does not actually mean I reviewed it (I didn't), but just trying to remove my "Changes requested" following the recent update to the PR -- this seems to be the only way to do it 😄
Which changed the modal title that is shown after clicking "ON" from "Before you go..." to "Turn off auto-renew" (for future reference). |
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/7542517 Thank you @dzver for including a screenshot in the description! This is really helpful for our translators. |
* Update the auto-renew toggle to use a link on Purchase Details This component is used in several places. All other places should remain intact. The change will replace the Toggle component with an On/Off button in the middle of the Auto-renew ON copy. * There's no cursor and the tabbing doesn't work Use a link button in order to make that work * Rename the Modal heading @DavidRothstein raised a concern about the flow not being immediately clear with this heading. Rename it to make it more clear what it is
Translation for this Pull Request has now been finished. |
This component is used in several places. All other places should remain intact.
The change will replace the Toggle component with an On/Off button in the middle of the Auto-renew ON copy.
Proposed Changes
This is how it works with the purchase owner:
https://user-images.githubusercontent.com/82778/191526566-15ec4e91-48d5-4919-9acc-6a58fbd31202.mov
And this is how it looks with another admin account:
Testing Instructions
Pre-merge Checklist
Related to #