Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Launchpad: Update "Set up" task title #68304

Merged
merged 1 commit into from
Sep 26, 2022
Merged

Conversation

jeyip
Copy link
Contributor

@jeyip jeyip commented Sep 26, 2022

Proposed Changes

  • Changes "Set up Newsletter" and "Set up Link in Bio" task title to "Personalize Newsletter" and "Personalize Link in Bio"

Screenshots

Before

Screen Shot 2022-09-26 at 12 56 24 PM

After

Screen Shot 2022-09-26 at 12 55 41 PM

Testing Instructions

  • Create link-in-bio or newsletter site https://wordpress.com/hp-2022-tailored-flows/
  • Stop at the launchpad view
  • Ensure that you're loading the local dev environment ( calypso.localhost:3000 )
  • Verify that "Set up" task title has changed to "Personalize"

Pre-merge Checklist

Related to #68034

@jeyip jeyip added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Feature] Launchpad The onboarding Launchpad that guides users through setting up their site and getting it launched. labels Sep 26, 2022
@jeyip jeyip self-assigned this Sep 26, 2022
@jeyip jeyip changed the title Reword set up site type to personalize site type Launchpad: Update "Set up" task title Sep 26, 2022
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@bstoynov bstoynov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Looks good in Chrome, Firefox, Edge, Safari

@jeyip jeyip merged commit ee53607 into trunk Sep 26, 2022
@jeyip jeyip deleted the fix/launchpad-setup-task-title branch September 26, 2022 22:00
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Sep 26, 2022
@a8ci18n
Copy link

a8ci18n commented Sep 27, 2022

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/7552670

Thank you @jeyip for including a screenshot in the description! This is really helpful for our translators.

@a8ci18n
Copy link

a8ci18n commented Oct 10, 2022

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Launchpad The onboarding Launchpad that guides users through setting up their site and getting it launched.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants