Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BBE: Experiment for BBE goal copy #68782

Merged
merged 9 commits into from
Oct 19, 2022
Merged

Conversation

ddc22
Copy link
Contributor

@ddc22 ddc22 commented Oct 7, 2022

Proposed Changes

  • Adds a loading animation for when the experiment is loading
  • Adds a different goals text for DIFM when the experiment treatment is active
  • We also preload the experiment when site is created to try and eliminate the loader in most cases.
  • The loader would be hidden for non EN users (when the BBE goal does not exist for display)

goalsexp

Testing Instructions

  • Create a site

  • Land on the post site creation goal step and make sure the normal UI is visible

  • Go to the experiment 20855-explat-experiment and activate the treatment cookie

  • Now refresh the goal step from above and make sure the treatment is visible

  • Loader Dynamics

  • When creating the site make sure that a loader is not visible when the experiment loads.

  • Refresh the page after 1 minute (TTL) and make sure a loader is visible

  • Change language to NON En and make sure the loader is never visible.

Pre-merge Checklist

@matticbot
Copy link
Contributor

matticbot commented Oct 7, 2022

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~2995 bytes added 📈 [gzipped])

name                   parsed_size           gzip_size
entry-stepper              +8469 B  (+0.2%)    +2986 B  (+0.3%)
entry-main                   +97 B  (+0.0%)      +31 B  (+0.0%)
entry-login                  +43 B  (+0.0%)      +22 B  (+0.0%)
entry-gutenboarding          +43 B  (+0.0%)      +22 B  (+0.0%)
entry-domains-landing        +43 B  (+0.0%)      +22 B  (+0.0%)
entry-browsehappy            +43 B  (+0.0%)      +22 B  (+0.1%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~3243 bytes added 📈 [gzipped])

name                   parsed_size           gzip_size
signup                     +8436 B  (+2.1%)    +3184 B  (+3.7%)
accept-invite              +8436 B  (+1.8%)    +3184 B  (+3.1%)
jetpack-connect            +1200 B  (+0.1%)     +469 B  (+0.2%)
plans                        +31 B  (+0.0%)      +16 B  (+0.0%)
pages                        +31 B  (+0.0%)      +20 B  (+0.0%)
jetpack-cloud-pricing        +31 B  (+0.0%)      +16 B  (+0.0%)
checkout                     +31 B  (+0.0%)      +16 B  (+0.0%)
plugins                      +18 B  (+0.0%)      +23 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~2383 bytes removed 📉 [gzipped])

name                           parsed_size           gzip_size
async-load-signup-steps-plans      -7143 B  (-2.1%)    -2383 B  (-2.4%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@ddc22 ddc22 requested a review from aneeshd16 October 7, 2022 16:59
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Oct 7, 2022
@ddc22 ddc22 marked this pull request as ready for review October 13, 2022 21:07
Copy link
Contributor

@aneeshd16 aneeshd16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests well! Confirmed that the experiment assignment is pre-fetched while site creation. However, the TTL needs to be increased for this to work. Users who choose a paid plan are taken to the checkout screen after the site is created. The user most probably spends more than 60s on the checkout screen.

Left some minor feedback below.

) }
</SelectCard>
) ) }
{ isBuiltByExpressExperimentLoading
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We hide the DIFM goal for non-EN locales. Can we add a check so that the placeholder is shown iff goalOptions contains the DIFM goal?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice suggestion!

client/lib/signup/step-actions/index.js Outdated Show resolved Hide resolved
client/lib/signup/step-actions/index.js Outdated Show resolved Hide resolved
@ddc22 ddc22 force-pushed the add/experiment-for-difm-goal-copy branch from 0ccbdf6 to 35a1cc7 Compare October 19, 2022 05:41
@ddc22 ddc22 requested a review from aneeshd16 October 19, 2022 06:13
@ddc22 ddc22 changed the title Experiment for DIFM goal copy BBE" Experiment for BBE goal copy Oct 19, 2022
@ddc22 ddc22 changed the title BBE" Experiment for BBE goal copy BBE: Experiment for BBE goal copy Oct 19, 2022
@ddc22 ddc22 merged commit 52c0c79 into trunk Oct 19, 2022
@ddc22 ddc22 deleted the add/experiment-for-difm-goal-copy branch October 19, 2022 06:54
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Oct 19, 2022
@a8ci18n
Copy link

a8ci18n commented Oct 19, 2022

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/7583967

Thank you @jdc91 for including a screenshot in the description! This is really helpful for our translators.

@ddc22 ddc22 self-assigned this Oct 20, 2022
@ddc22 ddc22 added the DIFM Express Built By Express Onboarding Pipeline related tasks label Oct 23, 2022
@a8ci18n
Copy link

a8ci18n commented Oct 27, 2022

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DIFM Express Built By Express Onboarding Pipeline related tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants