-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Jetpack Cancellation form input #68999
Conversation
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~17 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests well! I left one minor comment, but that's not a blocker.
|
||
// Disable continuation button if "Other" is selected but no reason is written in | ||
useEffect( () => { | ||
if ( surveyAnswerId === 'another-reason' && surveyAnswerText === '' ) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think about doing something like
if ( surveyAnswerId === 'another-reason' && surveyAnswerText.trim() === '' )
in order to avoid people leaving blank spaces as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good thinking, I'll add that
rest: 'Please share any additional details.', | ||
}; | ||
|
||
describe( 'JetpackCancellationSurvey', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice working adding tests.
- Add optional text field to each answer - Add "I no longer need my website" answer
3f3caec
to
6b99d88
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/7583345 Thank you @CodeyGuyDylan for including a screenshot in the description! This is really helpful for our translators. |
Translation for this Pull Request has now been finished. |
Proposed Changes
Discussion
P2s:
p1HpG7-hcM-p2
p1HpG7-hzP-p2
pbNhbs-3MF-p2
Asana:
1161179020265237-as-1202940054684628/f
Testing Instructions
git switch update/jetpack-cancellation-form-input
yarn start-jetpack-cloud
yarn start
Pre-merge Checklist